linux-kernel - Re: [PATCH v2 1/6] usb: musb: dma: Correct parameter passed to IRQ handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 30 Oct 2019 12:23:02 +0100
From:   Paul Cercueil <paul@...pouillou.net>
To:     Bin Liu <b-liu@...com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        od@...c.me, Artur Rojek <contact@...ur-rojek.eu>
Subject: Re: [PATCH v2 1/6] usb: musb: dma: Correct parameter passed to IRQ
 handler

Hi,


Le ven., oct. 25, 2019 at 13:47, Paul Cercueil <paul@...pouillou.net> a 
écrit :
> The IRQ handler was passed a pointer to a struct dma_controller, but 
> the
> argument was then casted to a pointer to a struct musb_dma_controller.
> 
> Signed-off-by: Paul Cercueil <paul@...pouillou.net>
> Tested-by: Artur Rojek <contact@...ur-rojek.eu>
> ---
> 
> Notes:
>     v2: Rebase on 4.5-rc4

Typo in the changelog of this patch and the following ones: it was 
rebased on 5.4-rc4, obviously.


> 
>  drivers/usb/musb/musbhsdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/musb/musbhsdma.c 
> b/drivers/usb/musb/musbhsdma.c
> index 5fc6825745f2..2d3751d885b4 100644
> --- a/drivers/usb/musb/musbhsdma.c
> +++ b/drivers/usb/musb/musbhsdma.c
> @@ -425,7 +425,7 @@ struct dma_controller 
> *musbhs_dma_controller_create(struct musb *musb,
>  	controller->controller.channel_abort = dma_channel_abort;
> 
>  	if (request_irq(irq, dma_controller_irq, 0,
> -			dev_name(musb->controller), &controller->controller)) {
> +			dev_name(musb->controller), controller)) {
>  		dev_err(dev, "request_irq %d failed!\n", irq);
>  		musb_dma_controller_destroy(&controller->controller);
> 
> --
> 2.23.0
>