linux-kernel - Re: [PATCH] fsnotify: Use NULL instead of 0 for pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dade5dda-6d1f-519d-e4e6-e29d2a44bed9@loongson.cn>
Date:   Wed, 30 Oct 2019 21:12:37 +0800
From:   Tiezhu Yang <yangtiezhu@...ngson.cn>
To:     Jan Kara <jack@...e.cz>
Cc:     Amir Goldstein <amir73il@...il.com>, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fsnotify: Use NULL instead of 0 for pointer

On 10/30/2019 08:21 PM, Jan Kara wrote:
> On Tue 29-10-19 21:39:02, Tiezhu Yang wrote:
>> Fix the following sparse warning:
>>
>> fs/notify/fdinfo.c:53:87: warning: Using plain integer as NULL pointer
>>
>> Fixes: be77196b809c ("fs, notify: add procfs fdinfo helper")
>> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
> Thanks for the patch but similar patch already sits in my tree as commit
> ddd06c36bdb "fsnotify/fdinfo: exportfs_encode_inode_fh() takes pointer as
> 4th argument". I'll send it to Linus in the next merge window.
>
> 								Honza

Thanks for your reply. I can not find your tree about fs/notify
in the MAINTAINERS file, so this patch is based on Linus's tree.
Sorry for the noise, you can ignore it.

By the way, could you add your tree in the MAINTAINERS file?

Thanks,

Tiezhu Yang

>
>> ---
>>   fs/notify/fdinfo.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/fs/notify/fdinfo.c b/fs/notify/fdinfo.c
>> index 1e2bfd2..cd2846e 100644
>> --- a/fs/notify/fdinfo.c
>> +++ b/fs/notify/fdinfo.c
>> @@ -50,7 +50,8 @@ static void show_mark_fhandle(struct seq_file *m, struct inode *inode)
>>   	f.handle.handle_bytes = sizeof(f.pad);
>>   	size = f.handle.handle_bytes >> 2;
>>   
>> -	ret = exportfs_encode_inode_fh(inode, (struct fid *)f.handle.f_handle, &size, 0);
>> +	ret = exportfs_encode_inode_fh(inode, (struct fid *)f.handle.f_handle,
>> +				       &size, NULL);
>>   	if ((ret == FILEID_INVALID) || (ret < 0)) {
>>   		WARN_ONCE(1, "Can't encode file handler for inotify: %d\n", ret);
>>   		return;
>> -- 
>> 2.1.0
>>
>>