linux-kernel - [PATCH v2] dump_stack: Avoid the livelock of the dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20191030031637.6025-1-haokexin@gmail.com>
Date:   Wed, 30 Oct 2019 11:16:37 +0800
From:   Kevin Hao <haokexin@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: [PATCH v2] dump_stack: Avoid the livelock of the dump_lock

In the current code, we use the atomic_cmpxchg() to serialize the
output of the dump_stack(), but this implementation suffers the
thundering herd problem. We have observed such kind of livelock on a
Marvell cn96xx board(24 cpus) when heavily using the dump_stack() in
a kprobe handler. Actually we can let the competitors to wait for
the releasing of the lock before jumping to atomic_cmpxchg(). This
will definitely mitigate the thundering herd problem. Thanks Linus
for the suggestion.

Fixes: b58d977432c8 ("dump_stack: serialize the output from dump_stack()")
Cc: stable@...r.kernel.org
Signed-off-by: Kevin Hao <haokexin@...il.com>
---
v2:
 1. Use the method suggested by Linus.
 2. Since this fix seems pretty simple, maybe it deserve to be
    backported to stable kernel. So CC the stable.

 lib/dump_stack.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/dump_stack.c b/lib/dump_stack.c
index 5cff72f18c4a..0062dfcafd63 100644
--- a/lib/dump_stack.c
+++ b/lib/dump_stack.c
@@ -106,7 +106,11 @@ asmlinkage __visible void dump_stack(void)
 		was_locked = 1;
 	} else {
 		local_irq_restore(flags);
-		cpu_relax();
+		/*
+		 * Wait the lock to release before jumping to atomic_cmpxchg()
+		 * in order to mitigate the thundering herd problem.
+		 */
+		do { cpu_relax(); } while (atomic_read(&dump_lock) != -1);
 		goto retry;
 	}
 
-- 
2.14.4