linux-kernel - Re: [PATCH] mm: mempolicy: fix the wrong return value and potential pages leak of mbind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191030213144.dd7cd8084d4171e29abba875@linux-foundation.org>
Date:   Wed, 30 Oct 2019 21:31:44 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Yang Shi <yang.shi@...ux.alibaba.com>
Cc:     lixinhai.lxh@...il.com, vbabka@...e.cz, mhocko@...e.com,
        mgorman@...hsingularity.net, stable@...r.kernel.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        "Li Xinhai" <lixinhai.lxh@...il.com>
Subject: Re: [PATCH] mm: mempolicy: fix the wrong return value and potential
 pages leak of mbind

On Wed, 30 Oct 2019 11:14:58 -0700 Yang Shi <yang.shi@...ux.alibaba.com> wrote:

> On 10/30/19 9:58 AM, Yang Shi wrote:
> > The commit d883544515aa ("mm: mempolicy: make the behavior consistent
> > when MPOL_MF_MOVE* and MPOL_MF_STRICT were specified") fixed the return
> > value of mbind() for a couple of corner cases.  But, it altered the
> > errno for some other cases, for example, mbind() should return -EFAULT
> > when part or all of the memory range specified by nodemask and maxnode
> > points  outside your accessible address space, or there was an unmapped
> > hole in the specified memory range specified by addr and len.
> >
> > Fixed this by preserving the errno returned by queue_pages_range().
> > And, the pagelist may be not empty even though queue_pages_range()
> > returns error, put the pages back to LRU since mbind_range() is not called
> > to really apply the policy so those pages should not be migrated, this
> > is also the old behavior before the problematic commit.
> Forgot fixes tag.
> 
> Fixes: d883544515aa ("mm: mempolicy: make the behavior consistent when 
> MPOL_MF_MOVE* and MPOL_MF_STRICT were specified")

What's the relationship between this patch and
http://lkml.kernel.org/r/201910291756045288126@gmail.com?