linux-kernel - Re: [PATCH v4 24/48] Input: atmel_mxt_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191031054209.GA44197@ubuntu-m2-xlarge-x86>
Date:   Wed, 30 Oct 2019 22:42:09 -0700
From:   Nathan Chancellor <natechancellor@...il.com>
To:     Jiada Wang <jiada_wang@...tor.com>
Cc:     jikos@...nel.org, benjamin.tissoires@...hat.com,
        rydberg@...math.org, dmitry.torokhov@...il.com,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        erosca@...adit-jv.com, Andrew_Gabbasov@...tor.com,
        clang-built-linux@...glegroups.com
Subject: Re: [PATCH v4 24/48] Input: atmel_mxt_ts - make bootloader interrupt
 driven

Hi Jiada,

On Thu, Oct 31, 2019 at 01:26:23PM +0800, kbuild test robot wrote:
> CC: kbuild-all@...ts.01.org
> In-Reply-To: <20191029072010.8492-25-jiada_wang@...tor.com>
> References: <20191029072010.8492-25-jiada_wang@...tor.com>
> TO: Jiada Wang <jiada_wang@...tor.com>
> CC: jikos@...nel.org, benjamin.tissoires@...hat.com, rydberg@...math.org, dmitry.torokhov@...il.com
> CC: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, jiada_wang@...tor.com, erosca@...adit-jv.com, Andrew_Gabbasov@...tor.com
> 
> Hi Jiada,
> 
> I love your patch! Perhaps something to improve:
> 
> [auto build test WARNING on input/next]
> [also build test WARNING on v5.4-rc5 next-20191030]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
> 
> url:    https://github.com/0day-ci/linux/commits/Jiada-Wang/atmel_mxt_ts-misc/20191031-032509
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
> config: arm64-defconfig (attached as .config)
> compiler: clang version 10.0.0 (git://gitmirror/llvm_project 6cb181f086a5bc69a97c1a01e9a36f8293dea7ed)
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=arm64 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@...el.com>
> 
> All warnings (new ones prefixed by >>):
> 
>    drivers/input/touchscreen/atmel_mxt_ts.c:1190:2: error: implicit declaration of function 'dev_debug' [-Werror,-Wimplicit-function-declaration]
>            dev_debug(dev, "T92 long stroke LSTR=%d %d\n",
>            ^
>    drivers/input/touchscreen/atmel_mxt_ts.c:1200:2: error: implicit declaration of function 'dev_debug' [-Werror,-Wimplicit-function-declaration]
>            dev_debug(dev, "T93 report double tap %d\n", status);
>            ^
> >> drivers/input/touchscreen/atmel_mxt_ts.c:1402:36: warning: address of 'data->flash->work' will always evaluate to 'true' [-Wpointer-bool-conversion]
>                    if (data->flash && &data->flash->work)
>                                    ~~  ~~~~~~~~~~~~~^~~~

The 0day team has been running clang builds for us and this warning
popped up because of this commit. Presumably, you will need to spin
up a v5 because of the other error, mind addressing this warning
while you are at it? As it points out, the check should be unnecessary,
unless you meant to check for something else?

>    1 warning and 2 errors generated.
> 
> vim +1402 drivers/input/touchscreen/atmel_mxt_ts.c
> 
>   1394	
>   1395	static irqreturn_t mxt_interrupt(int irq, void *dev_id)
>   1396	{
>   1397		struct mxt_data *data = dev_id;
>   1398	
>   1399		if (data->in_bootloader) {
>   1400			complete(&data->chg_completion);
>   1401	
> > 1402			if (data->flash && &data->flash->work)
>   1403				cancel_delayed_work_sync(&data->flash->work);
>   1404	
>   1405			return IRQ_RETVAL(mxt_check_bootloader(data));
>   1406		}
>   1407	
>   1408		if (!data->object_table)
>   1409			return IRQ_HANDLED;
>   1410	
>   1411		if (data->T44_address) {
>   1412			return mxt_process_messages_t44(data);
>   1413		} else {
>   1414			return mxt_process_messages(data);
>   1415		}
>   1416	}
>   1417	
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> 

Cheers,
Nathan