linux-kernel - Re: [PATCH] arch: x86: kvm: mmu.c: use true/false for bool type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 31 Oct 2019 12:27:39 +0530
From:   SAURAV GIREPUNJE <saurav.girepunje@...il.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     pbonzini@...hat.com, rkrcmar@...hat.com,
        sean.j.christopherson@...el.com, vkuznets@...hat.com,
        wanpengli@...cent.com, jmattson@...gle.com, joro@...tes.org,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, hpa@...or.com,
        x86@...nel.org, kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        saurav.girepunje@...mail.com
Subject: Re: [PATCH] arch: x86: kvm: mmu.c: use true/false for bool type

On Tue, Oct 29, 2019 at 04:44:23PM +0100, Peter Zijlstra wrote:
> On Tue, Oct 29, 2019 at 07:12:46PM +0530, SAURAV GIREPUNJE wrote:
> > On Tue, Oct 29, 2019 at 11:13:00AM +0100, Peter Zijlstra wrote:
> > > On Tue, Oct 29, 2019 at 03:11:04PM +0530, Saurav Girepunje wrote:
> > > > Use true/false for bool type "dbg" in mmu.c
> > > > 
> > > > Signed-off-by: Saurav Girepunje <saurav.girepunje@...il.com>
> > > > ---
> > > >  arch/x86/kvm/mmu.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> > > > index 24c23c66b226..c0b1df69ce0f 100644
> > > > --- a/arch/x86/kvm/mmu.c
> > > > +++ b/arch/x86/kvm/mmu.c
> > > > @@ -68,7 +68,7 @@ enum {
> > > >  #undef MMU_DEBUG
> > > >  
> > > >  #ifdef MMU_DEBUG
> > > > -static bool dbg = 0;
> > > > +static bool dbg = true;
> > > 
> > > You're actually changing the value from false to true. Please, if you
> > > don't know C, don't touch things.
> > Hi,
> > 
> > Thanks for your review.
> > I accept that I have given wrong value "true" to debug variable. It's my bad my typo mistake.  
> > I will make sure that I will not touch your exclusive C code where we can assign 0/1 to a bool variable,
> > As you have given me a free advice, I also request you to please don't review such small patches from newbie to discourage them.
> 
> I will most certainly review whatever I want, and clearly it is needed.
Do you want me to discard this patch or resend ?