linux-kernel - Re: [PATCH][next] rtw88: remove redundant null pointer check on arrays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191031080516.BFC5360907@smtp.codeaurora.org>
Date:   Thu, 31 Oct 2019 08:05:16 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Yan-Hsuan Chuang <yhchuang@...ltek.com>,
        "David S . Miller" <davem@...emloft.net>,
        Chris Chiu <chiu@...lessm.com>,
        Tzu-En Huang <tehuang@...ltek.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] rtw88: remove redundant null pointer check on arrays

Colin King <colin.king@...onical.com> wrote:

> From: Colin Ian King <colin.king@...onical.com>
> 
> The checks to see if swing_table->n or swing_table->p are null are
> redundant since n and p are arrays and can never be null if
> swing_table is non-null.  I believe these are redundant checks
> and can be safely removed, especially the checks implies that these
> are not arrays which can lead to confusion.
> 
> Addresses-Coverity: ("Array compared against 0")
> Fixes: c97ee3e0bea2 ("rtw88: add power tracking support")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Patch applied to wireless-drivers-next.git, thanks.

baff8da6e163 rtw88: remove redundant null pointer check on arrays

-- 
https://patchwork.kernel.org/patch/11212093/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches