linux-kernel - RE: [PATCH v4 4/8] dt-bindings: mmc: arasan: Add optional properties for Arasan SDHCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 31 Oct 2019 08:54:28 +0000
From:   Manish Narani <MNARANI@...inx.com>
To:     Ulf Hansson <ulf.hansson@...aro.org>
CC:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Michal Simek <michals@...inx.com>,
        Jolly Shah <JOLLYS@...inx.com>,
        Nava kishore Manne <navam@...inx.com>,
        Rajan Vaja <RAJANV@...inx.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        DTML <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        git <git@...inx.com>
Subject: RE: [PATCH v4 4/8] dt-bindings: mmc: arasan: Add optional properties
 for Arasan SDHCI

Hi Uffe,

Thanks for your comments. Please see below inline.

> -----Original Message-----
> From: Ulf Hansson <ulf.hansson@...aro.org>
> Sent: Wednesday, October 30, 2019 8:27 PM
> To: Manish Narani <MNARANI@...inx.com>
> Cc: Rob Herring <robh+dt@...nel.org>; Mark Rutland
> <mark.rutland@....com>; Adrian Hunter <adrian.hunter@...el.com>;
> Michal Simek <michals@...inx.com>; Jolly Shah <JOLLYS@...inx.com>; Nava
> kishore Manne <navam@...inx.com>; Rajan Vaja <RAJANV@...inx.com>;
> linux-mmc@...r.kernel.org; DTML <devicetree@...r.kernel.org>; Linux
> Kernel Mailing List <linux-kernel@...r.kernel.org>; Linux ARM <linux-arm-
> kernel@...ts.infradead.org>; git <git@...inx.com>
> Subject: Re: [PATCH v4 4/8] dt-bindings: mmc: arasan: Add optional
> properties for Arasan SDHCI
> 
> On Tue, 29 Oct 2019 at 11:30, Manish Narani <manish.narani@...inx.com>
> wrote:
> >
> > Add optional properties for Arasan SDHCI which are used to set clk delays
> > for different speed modes in the controller.
> >
> > Signed-off-by: Manish Narani <manish.narani@...inx.com>
> > ---
> >  .../devicetree/bindings/mmc/arasan,sdhci.txt     | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> > index b51e40b2e0c5..c0f505b6cab5 100644
> > --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> > @@ -46,6 +46,22 @@ Optional Properties:
> >      properly. Test mode can be used to force the controller to function.
> >    - xlnx,int-clock-stable-broken: when present, the controller always
> reports
> >      that the internal clock is stable even when it is not.
> > +  - arasan-clk-phase-legacy: Input/Output Clock Delay pair in degrees for
> Legacy Mode.
> > +  - arasan-clk-phase-mmc-hs: Input/Output Clock Delay pair degrees for
> MMC HS.
> > +  - arasan-clk-phase-sd-hs: Input/Output Clock Delay pair in degrees for SD
> HS.
> > +  - arasan-clk-phase-uhs-sdr12: Input/Output Clock Delay pair in degrees
> for SDR12.
> > +  - arasan-clk-phase-uhs-sdr25: Input/Output Clock Delay pair in degrees
> for SDR25.
> > +  - arasan-clk-phase-uhs-sdr50: Input/Output Clock Delay pair in degrees
> for SDR50.
> > +  - arasan-clk-phase-uhs-sdr104: Input/Output Clock Delay pair in degrees
> for SDR104.
> > +  - arasan-clk-phase-uhs-ddr50: Input/Output Clock Delay pair in degrees
> for SD DDR50.
> > +  - arasan-clk-phase-mmc-ddr52: Input/Output Clock Delay pair in degrees
> for MMC DDR52.
> > +  - arasan-clk-phase-mmc-hs200: Input/Output Clock Delay pair in degrees
> for MMC HS200.
> > +  - arasan-clk-phase-mmc-hs400: Input/Output Clock Delay pair in degrees
> for MMC HS400.
> 
> I don't mind if you convert these to common mmc bindings.
> 
> I think other controllers/platforms may find them useful, at least at
> some point, if not already.

That will be a good thing to do indeed. Will send v5 with making these properties as common.

Thanks,
Manish

> 
> > +
> > +  Above mentioned are the clock (phase) delays which are to be
> configured in the
> > +  controller while switching to particular speed mode. The range of values
> are
> > +  0 to 359 degrees. If not specified, driver will configure the default value
> > +  defined for particular mode in it.
> >
> >  Example:
> >         sdhci@...00000 {
> > --
> > 2.17.1
> >
> 
> Kind regards
> Uffe