| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20191031113426.69bb1468@collabora.com>
Date: Thu, 31 Oct 2019 11:34:26 +0100
From: Boris Brezillon <boris.brezillon@...labora.com>
To: <Tudor.Ambarus@...rochip.com>
Cc: <miquel.raynal@...tlin.com>, <richard@....at>, <vigneshr@...com>,
<linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 01/32] mtd: spi-nor: Prepend spi_nor_ to all Reg Ops
methods
On Tue, 29 Oct 2019 11:16:49 +0000
<Tudor.Ambarus@...rochip.com> wrote:
> From: Tudor Ambarus <tudor.ambarus@...rochip.com>
>
> All the core functions should begin with "spi_nor_".
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@...rochip.com>
Reviewed-by: Boris Brezillon <boris.brezillon@...labora.com>
> ---
> drivers/mtd/spi-nor/spi-nor.c | 110 +++++++++++++++++++++---------------------
> 1 file changed, 56 insertions(+), 54 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index a6f9f833c862..aca8245fb6c4 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -393,7 +393,7 @@ static ssize_t spi_nor_write_data(struct spi_nor *nor, loff_t to, size_t len,
> * Return the status register value.
> * Returns negative if error occurred.
> */
> -static int read_sr(struct spi_nor *nor)
> +static int spi_nor_read_sr(struct spi_nor *nor)
> {
> int ret;
>
> @@ -423,7 +423,7 @@ static int read_sr(struct spi_nor *nor)
> * Return the status register value.
> * Returns negative if error occurred.
> */
> -static int read_fsr(struct spi_nor *nor)
> +static int spi_nor_read_fsr(struct spi_nor *nor)
> {
> int ret;
>
> @@ -453,7 +453,7 @@ static int read_fsr(struct spi_nor *nor)
> * location. Return the configuration register value.
> * Returns negative if error occurred.
> */
> -static int read_cr(struct spi_nor *nor)
> +static int spi_nor_read_cr(struct spi_nor *nor)
> {
> int ret;
>
> @@ -482,7 +482,7 @@ static int read_cr(struct spi_nor *nor)
> * Write status register 1 byte
> * Returns negative if error occurred.
> */
> -static int write_sr(struct spi_nor *nor, u8 val)
> +static int spi_nor_write_sr(struct spi_nor *nor, u8 val)
> {
> nor->bouncebuf[0] = val;
> if (nor->spimem) {
> @@ -503,7 +503,7 @@ static int write_sr(struct spi_nor *nor, u8 val)
> * Set write enable latch with Write Enable command.
> * Returns negative if error occurred.
> */
> -static int write_enable(struct spi_nor *nor)
> +static int spi_nor_write_enable(struct spi_nor *nor)
> {
> if (nor->spimem) {
> struct spi_mem_op op =
> @@ -521,7 +521,7 @@ static int write_enable(struct spi_nor *nor)
> /*
> * Send write disable instruction to the chip.
> */
> -static int write_disable(struct spi_nor *nor)
> +static int spi_nor_write_disable(struct spi_nor *nor)
> {
> if (nor->spimem) {
> struct spi_mem_op op =
> @@ -644,9 +644,9 @@ static int st_micron_set_4byte(struct spi_nor *nor, bool enable)
> {
> int ret;
>
> - write_enable(nor);
> + spi_nor_write_enable(nor);
> ret = macronix_set_4byte(nor, enable);
> - write_disable(nor);
> + spi_nor_write_disable(nor);
>
> return ret;
> }
> @@ -700,9 +700,9 @@ static int winbond_set_4byte(struct spi_nor *nor, bool enable)
> * Register to be set to 1, so all 3-byte-address reads come from the
> * second 16M. We must clear the register to enable normal behavior.
> */
> - write_enable(nor);
> + spi_nor_write_enable(nor);
> ret = spi_nor_write_ear(nor, 0);
> - write_disable(nor);
> + spi_nor_write_disable(nor);
>
> return ret;
> }
> @@ -752,7 +752,7 @@ static int spi_nor_clear_sr(struct spi_nor *nor)
>
> static int spi_nor_sr_ready(struct spi_nor *nor)
> {
> - int sr = read_sr(nor);
> + int sr = spi_nor_read_sr(nor);
> if (sr < 0)
> return sr;
>
> @@ -786,7 +786,7 @@ static int spi_nor_clear_fsr(struct spi_nor *nor)
>
> static int spi_nor_fsr_ready(struct spi_nor *nor)
> {
> - int fsr = read_fsr(nor);
> + int fsr = spi_nor_read_fsr(nor);
> if (fsr < 0)
> return fsr;
>
> @@ -864,7 +864,7 @@ static int spi_nor_wait_till_ready(struct spi_nor *nor)
> *
> * Returns 0 if successful, non-zero otherwise.
> */
> -static int erase_chip(struct spi_nor *nor)
> +static int spi_nor_erase_chip(struct spi_nor *nor)
> {
> dev_dbg(nor->dev, " %lldKiB\n", (long long)(nor->mtd.size >> 10));
>
> @@ -1215,7 +1215,7 @@ static int spi_nor_erase_multi_sectors(struct spi_nor *nor, u64 addr, u32 len)
> list_for_each_entry_safe(cmd, next, &erase_list, list) {
> nor->erase_opcode = cmd->opcode;
> while (cmd->count) {
> - write_enable(nor);
> + spi_nor_write_enable(nor);
>
> ret = spi_nor_erase_sector(nor, addr);
> if (ret)
> @@ -1270,9 +1270,9 @@ static int spi_nor_erase(struct mtd_info *mtd, struct erase_info *instr)
> if (len == mtd->size && !(nor->flags & SNOR_F_NO_OP_CHIP_ERASE)) {
> unsigned long timeout;
>
> - write_enable(nor);
> + spi_nor_write_enable(nor);
>
> - if (erase_chip(nor)) {
> + if (spi_nor_erase_chip(nor)) {
> ret = -EIO;
> goto erase_err;
> }
> @@ -1298,7 +1298,7 @@ static int spi_nor_erase(struct mtd_info *mtd, struct erase_info *instr)
> /* "sector"-at-a-time erase */
> } else if (spi_nor_has_uniform_erase(nor)) {
> while (len) {
> - write_enable(nor);
> + spi_nor_write_enable(nor);
>
> ret = spi_nor_erase_sector(nor, addr);
> if (ret)
> @@ -1319,7 +1319,7 @@ static int spi_nor_erase(struct mtd_info *mtd, struct erase_info *instr)
> goto erase_err;
> }
>
> - write_disable(nor);
> + spi_nor_write_disable(nor);
>
> erase_err:
> spi_nor_unlock_and_unprep(nor, SPI_NOR_OPS_ERASE);
> @@ -1328,12 +1328,13 @@ static int spi_nor_erase(struct mtd_info *mtd, struct erase_info *instr)
> }
>
> /* Write status register and ensure bits in mask match written values */
> -static int write_sr_and_check(struct spi_nor *nor, u8 status_new, u8 mask)
> +static int spi_nor_write_sr_and_check(struct spi_nor *nor, u8 status_new,
> + u8 mask)
> {
> int ret;
>
> - write_enable(nor);
> - ret = write_sr(nor, status_new);
> + spi_nor_write_enable(nor);
> + ret = spi_nor_write_sr(nor, status_new);
> if (ret)
> return ret;
>
> @@ -1341,7 +1342,7 @@ static int write_sr_and_check(struct spi_nor *nor, u8 status_new, u8 mask)
> if (ret)
> return ret;
>
> - ret = read_sr(nor);
> + ret = spi_nor_read_sr(nor);
> if (ret < 0)
> return ret;
>
> @@ -1447,7 +1448,7 @@ static int stm_lock(struct spi_nor *nor, loff_t ofs, uint64_t len)
> bool can_be_top = true, can_be_bottom = nor->flags & SNOR_F_HAS_SR_TB;
> bool use_top;
>
> - status_old = read_sr(nor);
> + status_old = spi_nor_read_sr(nor);
> if (status_old < 0)
> return status_old;
>
> @@ -1509,7 +1510,7 @@ static int stm_lock(struct spi_nor *nor, loff_t ofs, uint64_t len)
> if ((status_new & mask) < (status_old & mask))
> return -EINVAL;
>
> - return write_sr_and_check(nor, status_new, mask);
> + return spi_nor_write_sr_and_check(nor, status_new, mask);
> }
>
> /*
> @@ -1527,7 +1528,7 @@ static int stm_unlock(struct spi_nor *nor, loff_t ofs, uint64_t len)
> bool can_be_top = true, can_be_bottom = nor->flags & SNOR_F_HAS_SR_TB;
> bool use_top;
>
> - status_old = read_sr(nor);
> + status_old = spi_nor_read_sr(nor);
> if (status_old < 0)
> return status_old;
>
> @@ -1592,7 +1593,7 @@ static int stm_unlock(struct spi_nor *nor, loff_t ofs, uint64_t len)
> if ((status_new & mask) > (status_old & mask))
> return -EINVAL;
>
> - return write_sr_and_check(nor, status_new, mask);
> + return spi_nor_write_sr_and_check(nor, status_new, mask);
> }
>
> /*
> @@ -1606,7 +1607,7 @@ static int stm_is_locked(struct spi_nor *nor, loff_t ofs, uint64_t len)
> {
> int status;
>
> - status = read_sr(nor);
> + status = spi_nor_read_sr(nor);
> if (status < 0)
> return status;
>
> @@ -1670,11 +1671,11 @@ static int spi_nor_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)
> * second byte will be written to the configuration register.
> * Return negative if error occurred.
> */
> -static int write_sr_cr(struct spi_nor *nor, u8 *sr_cr)
> +static int spi_nor_write_sr_cr(struct spi_nor *nor, u8 *sr_cr)
> {
> int ret;
>
> - write_enable(nor);
> + spi_nor_write_enable(nor);
>
> if (nor->spimem) {
> struct spi_mem_op op =
> @@ -1719,21 +1720,21 @@ static int macronix_quad_enable(struct spi_nor *nor)
> {
> int ret, val;
>
> - val = read_sr(nor);
> + val = spi_nor_read_sr(nor);
> if (val < 0)
> return val;
> if (val & SR_QUAD_EN_MX)
> return 0;
>
> - write_enable(nor);
> + spi_nor_write_enable(nor);
>
> - write_sr(nor, val | SR_QUAD_EN_MX);
> + spi_nor_write_sr(nor, val | SR_QUAD_EN_MX);
>
> ret = spi_nor_wait_till_ready(nor);
> if (ret)
> return ret;
>
> - ret = read_sr(nor);
> + ret = spi_nor_read_sr(nor);
> if (!(ret > 0 && (ret & SR_QUAD_EN_MX))) {
> dev_err(nor->dev, "Macronix Quad bit not set\n");
> return -EINVAL;
> @@ -1758,7 +1759,8 @@ static int macronix_quad_enable(struct spi_nor *nor)
> * some very old and few memories don't support this instruction. If a pull-up
> * resistor is present on the MISO/IO1 line, we might still be able to pass the
> * "read back" test because the QSPI memory doesn't recognize the command,
> - * so leaves the MISO/IO1 line state unchanged, hence read_cr() returns 0xFF.
> + * so leaves the MISO/IO1 line state unchanged, hence spi_nor_read_cr() returns
> + * 0xFF.
> *
> * bit 1 of the Configuration Register is the QE bit for Spansion like QSPI
> * memories.
> @@ -1772,12 +1774,12 @@ static int spansion_quad_enable(struct spi_nor *nor)
>
> sr_cr[0] = 0;
> sr_cr[1] = CR_QUAD_EN_SPAN;
> - ret = write_sr_cr(nor, sr_cr);
> + ret = spi_nor_write_sr_cr(nor, sr_cr);
> if (ret)
> return ret;
>
> /* read back and check it */
> - ret = read_cr(nor);
> + ret = spi_nor_read_cr(nor);
> if (!(ret > 0 && (ret & CR_QUAD_EN_SPAN))) {
> dev_err(nor->dev, "Spansion Quad bit not set\n");
> return -EINVAL;
> @@ -1805,7 +1807,7 @@ static int spansion_no_read_cr_quad_enable(struct spi_nor *nor)
> int ret;
>
> /* Keep the current value of the Status Register. */
> - ret = read_sr(nor);
> + ret = spi_nor_read_sr(nor);
> if (ret < 0) {
> dev_err(nor->dev, "error while reading status register\n");
> return -EINVAL;
> @@ -1813,7 +1815,7 @@ static int spansion_no_read_cr_quad_enable(struct spi_nor *nor)
> sr_cr[0] = ret;
> sr_cr[1] = CR_QUAD_EN_SPAN;
>
> - return write_sr_cr(nor, sr_cr);
> + return spi_nor_write_sr_cr(nor, sr_cr);
> }
>
> /**
> @@ -1836,7 +1838,7 @@ static int spansion_read_cr_quad_enable(struct spi_nor *nor)
> int ret;
>
> /* Check current Quad Enable bit value. */
> - ret = read_cr(nor);
> + ret = spi_nor_read_cr(nor);
> if (ret < 0) {
> dev_err(dev, "error while reading configuration register\n");
> return -EINVAL;
> @@ -1848,19 +1850,19 @@ static int spansion_read_cr_quad_enable(struct spi_nor *nor)
> sr_cr[1] = ret | CR_QUAD_EN_SPAN;
>
> /* Keep the current value of the Status Register. */
> - ret = read_sr(nor);
> + ret = spi_nor_read_sr(nor);
> if (ret < 0) {
> dev_err(dev, "error while reading status register\n");
> return -EINVAL;
> }
> sr_cr[0] = ret;
>
> - ret = write_sr_cr(nor, sr_cr);
> + ret = spi_nor_write_sr_cr(nor, sr_cr);
> if (ret)
> return ret;
>
> /* Read back and check it. */
> - ret = read_cr(nor);
> + ret = spi_nor_read_cr(nor);
> if (!(ret > 0 && (ret & CR_QUAD_EN_SPAN))) {
> dev_err(nor->dev, "Spansion Quad bit not set\n");
> return -EINVAL;
> @@ -1926,7 +1928,7 @@ static int sr2_bit7_quad_enable(struct spi_nor *nor)
> /* Update the Quad Enable bit. */
> *sr2 |= SR2_QUAD_EN_BIT7;
>
> - write_enable(nor);
> + spi_nor_write_enable(nor);
>
> ret = spi_nor_write_sr2(nor, sr2);
> if (ret < 0) {
> @@ -1964,15 +1966,15 @@ static int spi_nor_clear_sr_bp(struct spi_nor *nor)
> int ret;
> u8 mask = SR_BP2 | SR_BP1 | SR_BP0;
>
> - ret = read_sr(nor);
> + ret = spi_nor_read_sr(nor);
> if (ret < 0) {
> dev_err(nor->dev, "error while reading status register\n");
> return ret;
> }
>
> - write_enable(nor);
> + spi_nor_write_enable(nor);
>
> - ret = write_sr(nor, ret & ~mask);
> + ret = spi_nor_write_sr(nor, ret & ~mask);
> if (ret) {
> dev_err(nor->dev, "write to status register failed\n");
> return ret;
> @@ -2004,7 +2006,7 @@ static int spi_nor_spansion_clear_sr_bp(struct spi_nor *nor)
> u8 *sr_cr = nor->bouncebuf;
>
> /* Check current Quad Enable bit value. */
> - ret = read_cr(nor);
> + ret = spi_nor_read_cr(nor);
> if (ret < 0) {
> dev_err(nor->dev,
> "error while reading configuration register\n");
> @@ -2018,7 +2020,7 @@ static int spi_nor_spansion_clear_sr_bp(struct spi_nor *nor)
> if (ret & CR_QUAD_EN_SPAN) {
> sr_cr[1] = ret;
>
> - ret = read_sr(nor);
> + ret = spi_nor_read_sr(nor);
> if (ret < 0) {
> dev_err(nor->dev,
> "error while reading status register\n");
> @@ -2026,7 +2028,7 @@ static int spi_nor_spansion_clear_sr_bp(struct spi_nor *nor)
> }
> sr_cr[0] = ret & ~mask;
>
> - ret = write_sr_cr(nor, sr_cr);
> + ret = spi_nor_write_sr_cr(nor, sr_cr);
> if (ret)
> dev_err(nor->dev, "16-bit write register failed\n");
> return ret;
> @@ -2602,7 +2604,7 @@ static int sst_write(struct mtd_info *mtd, loff_t to, size_t len,
> if (ret)
> return ret;
>
> - write_enable(nor);
> + spi_nor_write_enable(nor);
>
> nor->sst_write_second = false;
>
> @@ -2641,14 +2643,14 @@ static int sst_write(struct mtd_info *mtd, loff_t to, size_t len,
> }
> nor->sst_write_second = false;
>
> - write_disable(nor);
> + spi_nor_write_disable(nor);
> ret = spi_nor_wait_till_ready(nor);
> if (ret)
> goto sst_write_err;
>
> /* Write out trailing byte if it exists. */
> if (actual != len) {
> - write_enable(nor);
> + spi_nor_write_enable(nor);
>
> nor->program_opcode = SPINOR_OP_BP;
> ret = spi_nor_write_data(nor, to, 1, buf + actual);
> @@ -2659,7 +2661,7 @@ static int sst_write(struct mtd_info *mtd, loff_t to, size_t len,
> ret = spi_nor_wait_till_ready(nor);
> if (ret)
> goto sst_write_err;
> - write_disable(nor);
> + spi_nor_write_disable(nor);
> actual += 1;
> }
> sst_write_err:
> @@ -2711,7 +2713,7 @@ static int spi_nor_write(struct mtd_info *mtd, loff_t to, size_t len,
>
> addr = spi_nor_convert_addr(nor, addr);
>
> - write_enable(nor);
> + spi_nor_write_enable(nor);
> ret = spi_nor_write_data(nor, addr, page_remain, buf + i);
> if (ret < 0)
> goto write_err;
Powered by blists - more mailing lists