linux-kernel - Re: [PATCH v2 2/4] iio: adc: ad7091r5: Add scale and external VREF support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 31 Oct 2019 18:56:48 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Beniamin Bia <beniamin.bia@...log.com>
Cc:     kbuild-all@...ts.01.org, jic23@...nel.org,
        devel@...verdev.osuosl.org, mark.rutland@....com, lars@...afoo.de,
        biabeniamin@...look.com, Michael.Hennerich@...log.com,
        devicetree@...r.kernel.org, linux-iio@...r.kernel.org,
        gregkh@...uxfoundation.org, linus.walleij@...aro.org,
        linux-kernel@...r.kernel.org, nicolas.ferre@...rochip.com,
        robh+dt@...nel.org, Beniamin Bia <beniamin.bia@...log.com>,
        pmeerw@...erw.net, knaack.h@....de, mchehab+samsung@...nel.org,
        paulmck@...ux.ibm.com, Paul Cercueil <paul.cercueil@...log.com>
Subject: Re: [PATCH v2 2/4] iio: adc: ad7091r5: Add scale and external VREF
 support

Hi Beniamin,

I love your patch! Perhaps something to improve:

[auto build test WARNING on iio/togreg]
[also build test WARNING on v5.4-rc5 next-20191030]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Beniamin-Bia/iio-adc-Add-support-for-AD7091R5-ADC/20191031-100114
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-dirty
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/iio/adc/ad7091r-base.c:207:6: sparse: sparse: symbol 'ad7091r_remove' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation