linux-kernel - Re: [BUGFIX PATCH v3 0/5] selftests: Fixes for 32bit arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191031202317.d264b984c4749af7abd43a84@kernel.org>
Date:   Thu, 31 Oct 2019 20:23:17 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org, jaswinder.singh@...aro.org,
        Alexey Dobriyan <adobriyan@...il.com>,
        Anshuman Khandual <khandual@...ux.vnet.ibm.com>,
        "Aneesh Kumar K . V" <aneesh.kumar@...ux.vnet.ibm.com>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        Willem de Bruijn <willemb@...gle.com>,
        Emilio López <emilio.lopez@...labora.co.uk>
Subject: Re: [BUGFIX PATCH v3 0/5] selftests: Fixes for 32bit arch

Hi,

Would anyone is OK for this fix?

I also found a typo on arm64 build... will send soon.

Thanks,

On Wed, 23 Oct 2019 13:57:30 +0900
Masami Hiramatsu <mhiramat@...nel.org> wrote:

> Hi,
> 
> Here are the 3rd version of kselftest fixes some on 32bit arch
> (e.g. arm)
> 
> In this version, I updated [1/5] to make va_max 1MB unconditionally
> according to Alexey's comment.
> 
> When I built the ksefltest on arm, I hit some 32bit related warnings.
> Here are the patches to fix those issues.
> 
> 
>  - [1/5] va_max was set 2^32 even on 32bit arch. This can make
>         va_max == 0 and always fail. Make it 1GB unconditionally.
>  - [2/5] Some VM tests requires 64bit user space, which should
>         not run on 32bit arch.
>  - [3/5] For counting the size of large file, we should use
>         size_t instead of unsinged long.
>  - [4/5] Gcc warns printf format for size_t and int64_t on
>         32bit arch. Use %llu and cast it.
>  - [5/5] Gcc warns __u64 and pointer type castings. It should
>         once translated to unsigned long.
> 
> Thank you,
> 
> ---
> 
> Masami Hiramatsu (5):
>       selftests: proc: Make va_max 1MB
>       selftests: vm: Build/Run 64bit tests only on 64bit arch
>       selftests: net: Use size_t and ssize_t for counting file size
>       selftests: net: Fix printf format warnings on arm
>       selftests: sync: Fix cast warnings on arm
> 
> 
>  tools/testing/selftests/net/so_txtime.c            |    4 ++--
>  tools/testing/selftests/net/tcp_mmap.c             |    8 ++++----
>  tools/testing/selftests/net/udpgso.c               |    3 ++-
>  tools/testing/selftests/net/udpgso_bench_tx.c      |    3 ++-
>  .../selftests/proc/proc-self-map-files-002.c       |    6 +++++-
>  tools/testing/selftests/sync/sync.c                |    6 +++---
>  tools/testing/selftests/vm/Makefile                |    5 +++++
>  tools/testing/selftests/vm/run_vmtests             |   10 ++++++++++
>  8 files changed, 33 insertions(+), 12 deletions(-)
> 
> --
> Masami Hiramatsu (Linaro) <mhiramat@...nel.org>


-- 
Masami Hiramatsu <mhiramat@...nel.org>