[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191031125100.qprbdaaysg3tmhif@hendrix>
Date: Thu, 31 Oct 2019 13:51:00 +0100
From: Maxime Ripard <mripard@...nel.org>
To: Torsten Duwe <duwe@....de>
Cc: Maxime Ripard <maxime.ripard@...tlin.com>,
Chen-Yu Tsai <wens@...e.org>, Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Thierry Reding <thierry.reding@...il.com>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
Andrzej Hajda <a.hajda@...sung.com>,
Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
Icenowy Zheng <icenowy@...c.io>,
Sean Paul <seanpaul@...omium.org>,
Vasily Khoruzhick <anarsoul@...il.com>,
Harald Geyer <harald@...ib.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Thomas Gleixner <tglx@...utronix.de>,
dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 6/7] dt-bindings: Add ANX6345 DP/eDP transmitter
binding
On Tue, Oct 29, 2019 at 01:16:57PM +0100, Torsten Duwe wrote:
> The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed
> for portable devices.
>
> Add a binding document for it.
>
> Signed-off-by: Icenowy Zheng <icenowy@...c.io>
> Signed-off-by: Vasily Khoruzhick <anarsoul@...il.com>
> Reviewed-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Torsten Duwe <duwe@...e.de>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> ---
> .../bindings/display/bridge/anx6345.yaml | 92 ++++++++++++++++++++++
> 1 file changed, 92 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/anx6345.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/anx6345.yaml b/Documentation/devicetree/bindings/display/bridge/anx6345.yaml
> new file mode 100644
> index 000000000000..094e8e8a5faa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/anx6345.yaml
> @@ -0,0 +1,92 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/anx6345.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analogix ANX6345 eDP Transmitter Device Tree Bindings
> +
> +maintainers:
> + - Torsten Duwe <duwe@....de>
> +
> +description: |
> + The ANX6345 is an ultra-low power Full-HD eDP transmitter designed for
> + portable devices.
> +
> +properties:
> + compatible:
> + const: analogix,anx6345
> +
> + reg:
> + maxItems: 1
> + description: base I2C address of the device
> +
> + reset-gpios:
> + maxItems: 1
> + description: GPIO connected to active low reset
> +
> + dvdd12-supply:
> + maxItems: 1
> + description: Regulator for 1.2V digital core power.
> +
> + dvdd25-supply:
> + maxItems: 1
> + description: Regulator for 2.5V digital core power.
> +
> + ports:
> + anyOf:
> + - port@0:
> + description: Video port for LVTTL input
> + - port@1:
> + description: Video port for eDP output (panel or connector).
> + May be omitted if EDID works reliably.
> + required:
> + - port@0
Have you tried to validate those two ports in a DT?
I'm not quite sure what you wanted to express with that anyOf, but if
it was something like port@0 is mandatory, and port@1 is optional, it
should be something like this:
properties:
...
ports:
type: object
properties:
port@0:
type: object
description: |
Video port for LVTTL input
port@1:
type: object
description: |
Video port for eDP output (..)
required:
- port@0
This way, you express that both port@0 and port@1 must by nodes, under
a node called ports, and port@0 is mandatory.
You should even push this a bit further by adding
additionalProperties: false to prevent a DT from having undocumented
properties and children for the main node and ports node.
Maxime
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists