linux-kernel - Re: [PATCH v2 11/11] ARM: dts: imx6ul-kontron-n6310-s-43: Add missing includes for GPIOs and IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191031130748.GC27967@pi3>
Date:   Thu, 31 Oct 2019 14:07:48 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Schrempf Frieder <frieder.schrempf@...tron.de>
Cc:     Fabio Estevam <festevam@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 11/11] ARM: dts: imx6ul-kontron-n6310-s-43: Add
 missing includes for GPIOs and IRQs

On Tue, Oct 29, 2019 at 11:28:16AM +0000, Schrempf Frieder wrote:
> From: Frieder Schrempf <frieder.schrempf@...tron.de>
> 
> Signed-off-by: Frieder Schrempf <frieder.schrempf@...tron.de>
> Fixes: 1ea4b76cdfde ("ARM: dts: imx6ul-kontron-n6310: Add Kontron i.MX6UL N6310 SoM and boards")
> ---
>  arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts b/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts
> index 5bad29683cc3..295bc3138fea 100644
> --- a/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts
> +++ b/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts
> @@ -7,6 +7,9 @@
>  
>  #include "imx6ul-kontron-n6310-s.dts"
>  
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/gpio/gpio.h>

This is not needed. This includes imx6ul-kontron-n6310-s.dts, which
includes imx6ul-kontron-n6310-som.dtsi which has proper GPIO include. It
also polls imx6ul.dtsi which has the IRQ defines.

My comment from v1 was for a case where you have a DTSI standing on its
own. If it does not include anything else, then it should have all
necessary inclusions (not only GPIO but also iMX-specific pinctrl and clock).

Best regards,
Krzysztof


> +
>  / {
>  	model = "Kontron N6310 S 43";
>  	compatible = "kontron,imx6ul-n6310-s-43", "kontron,imx6ul-n6310-s",
> -- 
> 2.17.1