linux-kernel - Re: [PATCH v2] Revert "nvme: Add quirk for Kingston NVME SSD running FW E8FK11.T"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191031132853.GA46011@google.com>
Date:   Thu, 31 Oct 2019 08:28:53 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Jian-Hong Pan <jian-hong@...lessm.com>
Cc:     Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...com>,
        Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        linux-nvme@...ts.infradead.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux@...lessm.com,
        stable@...r.kernel.org
Subject: Re: [PATCH v2] Revert "nvme: Add quirk for Kingston NVME SSD running
 FW E8FK11.T"

On Thu, Oct 31, 2019 at 05:34:09PM +0800, Jian-Hong Pan wrote:
> Since commit 253eaf4faaaa ("PCI/MSI: Fix incorrect MSI-X masking on
> resume") is merged, we can revert the previous quirk now.

253eaf4faaaa is pending on my pci/msi branch, planned to be merged
during the v5.5 merge window.

This revert patch must not be merged before 253eaf4faaaa.  The easiest
way to do that would be for me to merge this one as well; otherwise
we have to try to make things happen in the right order during the
merge window.

If the NVMe folks ack this idea and the patch, I'd be happy to merge
it.

> This reverts commit 19ea025e1d28c629b369c3532a85b3df478cc5c6.
> 
> Fixes: 19ea025e1d28 ("nvme: Add quirk for Kingston NVME SSD running FW E8FK11.T")
> Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=204887
> Signed-off-by: Jian-Hong Pan <jian-hong@...lessm.com>
> Cc: stable@...r.kernel.org
> ---
> v2:
>   Re-send for mailing failure
> 
>  drivers/nvme/host/core.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index fa7ba09dca77..94bfbee1e5f7 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -2404,16 +2404,6 @@ static const struct nvme_core_quirk_entry core_quirks[] = {
>  		.vid = 0x14a4,
>  		.fr = "22301111",
>  		.quirks = NVME_QUIRK_SIMPLE_SUSPEND,
> -	},
> -	{
> -		/*
> -		 * This Kingston E8FK11.T firmware version has no interrupt
> -		 * after resume with actions related to suspend to idle
> -		 * https://bugzilla.kernel.org/show_bug.cgi?id=204887
> -		 */
> -		.vid = 0x2646,
> -		.fr = "E8FK11.T",
> -		.quirks = NVME_QUIRK_SIMPLE_SUSPEND,
>  	}
>  };
>  
> -- 
> 2.23.0
>