linux-kernel - Re: [PATCH -next] gpu: host1x: Fix compile test failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb0a976a-0148-d554-15ff-5f4059eccd37@huawei.com>
Date:   Thu, 31 Oct 2019 21:33:38 +0800
From:   Yuehaibing <yuehaibing@...wei.com>
To:     Dmitry Osipenko <digetx@...il.com>, <thierry.reding@...il.com>,
        <mperttunen@...dia.com>, <arnd@...db.de>, <seanpaul@...omium.org>
CC:     <dri-devel@...ts.freedesktop.org>, <linux-tegra@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] gpu: host1x: Fix compile test failure

On 2019/10/31 6:26, Dmitry Osipenko wrote:
> 30.10.2019 16:54, YueHaibing пишет:
>> If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and
>> COMPILE_TEST is y, building fails:
>>
>> drivers/gpu/host1x/dev.o: In function `host1x_remove':
>> dev.c:(.text+0x624): undefined reference to `put_iova_domain'
>> dev.c:(.text+0x624): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `put_iova_domain'
>> dev.c:(.text+0x62c): undefined reference to `iova_cache_put'
>> dev.c:(.text+0x62c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `iova_cache_put'
>>
>> Select IOMMU_IOVA while COMPILE_TEST is set to fix this.
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Fixes: 52499a6ad2ae ("gpu: host1x: select IOMMU_IOVA")
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
>>  drivers/gpu/host1x/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
>> index cf987a3..354232d 100644
>> --- a/drivers/gpu/host1x/Kconfig
>> +++ b/drivers/gpu/host1x/Kconfig
>> @@ -2,7 +2,7 @@
>>  config TEGRA_HOST1X
>>  	tristate "NVIDIA Tegra host1x driver"
>>  	depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
>> -	select IOMMU_IOVA if IOMMU_SUPPORT
>> +	select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST)
>>  	help
>>  	  Driver for the NVIDIA Tegra host1x hardware.
>>  
>>
> 
> It should be better to unconditionally select IOMMU_IOVA here.
> 
> The same could be done for drivers/staging/media/tegra-vde/ and
> drivers/gpu/host1x/, please see [1].

Yep, I will repost, thanks!

> 
> [1] https://lore.kernel.org/linux-iommu/20190829154902.GC19842@ulmo/
> 
> .
>