linux-kernel - Re: [PATCH v10 4/4] PCI: Allow extend_bridge_window() to shrink resource if necessary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SL2P216MB0187930B744883ACBE240E0C80630@SL2P216MB0187.KORP216.PROD.OUTLOOK.COM>
Date:   Thu, 31 Oct 2019 14:34:18 +0000
From:   Nicholas Johnson <nicholas.johnson-opensource@...look.com.au>
To:     "mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "corbet@....net" <corbet@....net>,
        "benh@...nel.crashing.org" <benh@...nel.crashing.org>,
        "logang@...tatee.com" <logang@...tatee.com>
Subject: Re: [PATCH v10 4/4] PCI: Allow extend_bridge_window() to shrink
 resource if necessary

On Wed, Oct 30, 2019 at 03:49:39PM +0200, mika.westerberg@...ux.intel.com wrote:
> On Wed, Oct 30, 2019 at 01:33:26PM +0000, Nicholas Johnson wrote:
> > On Wed, Oct 30, 2019 at 03:25:09PM +0200, mika.westerberg@...ux.intel.com wrote:
> > > On Wed, Oct 30, 2019 at 12:47:44PM +0000, Nicholas Johnson wrote:
> > > > Remove checks for resource size in extend_bridge_window(). This is
> > > > necessary to allow the pci_bus_distribute_available_resources() to
> > > > function when the kernel parameter pci=hpmemsize=nn[KMG] is used to
> > > > allocate resources. Because the kernel parameter sets the size of all
> > > > hotplug bridges to be the same, there are problems when nested hotplug
> > > > bridges are encountered. Fitting a downstream hotplug bridge with size X
> > > > and normal bridges with non-zero size Y into parent hotplug bridge with
> > > > size X is impossible, and hence the downstream hotplug bridge needs to
> > > > shrink to fit into its parent.
> > > > 
> > > > Add check for if bridge is extended or shrunken and adjust pci_dbg to
> > > > reflect this.
> > > > 
> > > > Reset the resource if its new size is zero (if we have run out of a
> > > > bridge window resource) to prevent the PCI resource assignment code from
> > > > attempting to assign a zero-sized resource.
> > > > 
> > > > Rename extend_bridge_window() to adjust_bridge_window() to reflect the
> > > > fact that the window can now shrink.
> > > > 
> > > > Signed-off-by: Nicholas Johnson <nicholas.johnson-opensource@...look.com.au>
> > > 
> > > Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> > Do I need to re-post with this line in it?
> 
> No. Typically maintainers add these when they apply the patch.
Cheers, only 1/4 (the biggest one) is left to review. I will try to post 
the patch for the bugfix again soon, also.