linux-kernel - Re: [PATCH v1 2/2] interconnect: Remove unused module exit code from core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191031183233.GM1929@tuxbook-pro>
Date:   Thu, 31 Oct 2019 11:32:33 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Jordan Crouse <jcrouse@...eaurora.org>
Cc:     Georgi Djakov <georgi.djakov@...aro.org>,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v1 2/2] interconnect: Remove unused module exit code from
 core

On Thu 31 Oct 11:28 PDT 2019, Jordan Crouse wrote:

> The interconnect core is currently always built in:
> 
>  menuconfig INTERCONNECT
> 	bool "On-Chip Interconnect management support"
> 
> So remove the module_exit function and symbolically rename module_init
> to device_initcall to drive home the point.
> 
> Signed-off-by: Jordan Crouse <jcrouse@...eaurora.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

> ---
> 
>  drivers/interconnect/core.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
> index c498796..61aba50 100644
> --- a/drivers/interconnect/core.c
> +++ b/drivers/interconnect/core.c
> @@ -805,12 +805,7 @@ static int __init icc_init(void)
>  	return 0;
>  }
>  
> -static void __exit icc_exit(void)
> -{
> -	debugfs_remove_recursive(icc_debugfs_dir);
> -}
> -module_init(icc_init);
> -module_exit(icc_exit);
> +device_initcall(icc_init);
>  
>  MODULE_AUTHOR("Georgi Djakov <georgi.djakov@...aro.org>");
>  MODULE_DESCRIPTION("Interconnect Driver Core");
> -- 
> 2.7.4
>