linux-kernel - Re: [PATCH v2 1/2] pinctrl: Add pinmux & GPIO controller driver for a new SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201911011605.ffJ1jVSk%lkp@intel.com>
Date:   Fri, 1 Nov 2019 16:14:32 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Rahul Tanwar <rahul.tanwar@...ux.intel.com>
Cc:     kbuild-all@...ts.01.org, linus.walleij@...aro.org,
        robh+dt@...nel.org, mark.rutland@....com,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, robh@...nel.org,
        andriy.shevchenko@...el.com, qi-ming.wu@...el.com,
        yixin.zhu@...ux.intel.com, cheol.yong.kim@...el.com,
        Rahul Tanwar <rahul.tanwar@...ux.intel.com>
Subject: Re: [PATCH v2 1/2] pinctrl: Add pinmux & GPIO controller driver for
 a new SoC

Hi Rahul,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pinctrl/devel]
[also build test ERROR on v5.4-rc5 next-20191031]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Rahul-Tanwar/pinctrl-Add-new-pinctrl-GPIO-driver/20191101-120332
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: um-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=um 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/pinctrl/pinctrl-equilibrium.c: In function 'gpiochip_setup':
>> drivers/pinctrl/pinctrl-equilibrium.c:175:4: error: 'struct gpio_chip' has no member named 'of_node'
     gc->of_node = desc->node;
       ^~

vim +175 drivers/pinctrl/pinctrl-equilibrium.c

   166	
   167	static int gpiochip_setup(struct device *dev, struct eqbr_gpio_desc *desc)
   168	{
   169		struct gpio_irq_chip *girq;
   170		struct gpio_chip *gc;
   171	
   172		gc = &desc->chip;
   173		gc->owner = THIS_MODULE;
   174		gc->label = desc->name;
 > 175		gc->of_node = desc->node;
   176	
   177		if (!of_property_read_bool(desc->node, "interrupt-controller")) {
   178			dev_info(dev, "gc %s: doesn't act as interrupt controller!\n",
   179				 desc->name);
   180			return 0;
   181		}
   182	
   183		desc->ic.name = "gpio_irq";
   184		desc->ic.irq_mask = eqbr_gpio_disable_irq;
   185		desc->ic.irq_unmask = eqbr_gpio_enable_irq;
   186		desc->ic.irq_ack = eqbr_gpio_ack_irq;
   187		desc->ic.irq_mask_ack = eqbr_gpio_mask_ack_irq;
   188		desc->ic.irq_set_type = eqbr_gpio_set_irq_type;
   189	
   190		girq = &desc->chip.irq;
   191		girq->chip = &desc->ic;
   192		girq->parent_handler = eqbr_irq_handler;
   193		girq->num_parents = 1;
   194		girq->parents = devm_kcalloc(dev, 1, sizeof(*girq->parents),
   195					     GFP_KERNEL);
   196		if (!girq->parents)
   197			return -ENOMEM;
   198	
   199		girq->default_type = IRQ_TYPE_NONE;
   200		girq->handler = handle_level_irq;
   201		girq->parents[0] = desc->virq;
   202	
   203		return 0;
   204	}
   205	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (21984 bytes)