linux-kernel - Re: [PATCH v5 7/7] perf report: Sort by sampled cycles percent per block for tui

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191101083426.GC2172@krava>
Date:   Fri, 1 Nov 2019 09:34:26 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Jin Yao <yao.jin@...ux.intel.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v5 7/7] perf report: Sort by sampled cycles percent per
 block for tui

On Wed, Oct 30, 2019 at 02:04:30PM +0800, Jin Yao wrote:

SNIP

> +
>  static int perf_evlist__tty_browse_hists(struct evlist *evlist,
>  					 struct report *rep,
>  					 const char *help)
> @@ -605,6 +624,11 @@ static int report__browse_hists(struct report *rep)
>  
>  	switch (use_browser) {
>  	case 1:
> +		if (rep->total_cycles_mode) {
> +			ret = perf_evlist__tui_block_hists_browse(evlist, rep);
> +			break;
> +		}

does this have sense only for cycles event? what if I do:
  # perf record -b -e cycles,cache-misses

jirka

> +
>  		ret = perf_evlist__tui_browse_hists(evlist, help, NULL,
>  						    rep->min_percent,
>  						    &session->header.env,
> @@ -1408,12 +1432,8 @@ int cmd_report(int argc, const char **argv)
>  	if (report.total_cycles_mode) {
>  		if (sort__mode != SORT_MODE__BRANCH)
>  			report.total_cycles_mode = false;
> -		else if (!report.use_stdio) {
> -			pr_err("Error: --total-cycles can be only used together with --stdio\n");
> -			goto error;
> -		} else {
> +		else
>  			sort_order = "sym";
> -		}
>  	}
>  
>  	if (strcmp(input_name, "-") != 0)

SNIP