linux-kernel - Re: [PATCH 2/3] ARM: dts: sun8i: add FriendlyARM NanoPi Duo2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <FbCSL9o7LLRZJoCAokdTzGW6y5cRWs88rHTPoqG2238c@mailpile>
Date:   Fri, 01 Nov 2019 10:00:33 -0000
From:   Karl Palsson <karlp@...ak.net.au>
To:     "Chen-Yu Tsai" <wens@...e.org>
Cc:     "Maxime Ripard" <mripard@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] ARM: dts: sun8i: add FriendlyARM NanoPi Duo2


Chen-Yu Tsai <wens@...e.org> wrote:

(will fix all other comments)

> > +               // on opi-win, shutdown is pl4, is BT-RST-N is moduel pin 34
> > +               // YES; PG13 is correct.
> 
> I'm guessing all these comments are from your development
> cycle? Please remove them.

Yes, gross mistake squishing it all and rebasing, my apologies.

> 
> > +               shutdown-gpios = <&pio 6 13 GPIO_ACTIVE_HIGH>; /* PG13 */
> > +       };
> > +};
> 
> The board also has SPI flash. Can you add that as well?

It doesn't come mounted standard, it's just a blank footprint, so
I felt it should be left out?

Sincerely,
Karl Palsson

Download attachment "OpenPGP-digital-signature.html" of type "application/pgp-signature" (1176 bytes)