linux-kernel - Re: [PATCH -next] serial: uartlite: Missing uart_unregister_driver() on error in ulite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191101114153.GC3657@localhost>
Date:   Fri, 1 Nov 2019 12:41:53 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Mao Wenan <maowenan@...wei.com>
Cc:     jacmet@...site.dk, gregkh@...uxfoundation.org, jslaby@...e.com,
        shubhrajyoti.datta@...inx.com, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] serial: uartlite: Missing uart_unregister_driver()
 on error in ulite_probe()

On Fri, Nov 01, 2019 at 07:19:50PM +0800, Mao Wenan wrote:
> If uart_register_driver(&ulite_uart_driver) is success,
> but followed function is failed in ulite_probe, it needs to call
> uart_unregister_driver to unregister.
> 
> Fixes: f33cf776617b ("serial-uartlite: Move the uart register")
> Signed-off-by: Mao Wenan <maowenan@...wei.com>

No, this is broken. The driver is deregistered at module unload.

That said, f33cf776617b ("serial-uartlite: Move the uart register")
should never have been merged as I have pointed out before:

	https://lkml.kernel.org/r/20190523091839.GC568@localhost

I'll see if I can find some time to revisit this and start yelling at
Xilinx people again.

Johan