linux-kernel - Re: [PATCH] reset: brcmstb: Fix resource checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0f0c6be8-0e3c-7294-75aa-58c3b33d621e@gmail.com>
Date:   Thu, 31 Oct 2019 20:09:13 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     linux-arm-kernel@...r.kernel.org,
        Philipp Zabel <p.zabel@...gutronix.de>
Cc:     "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <bcm-kernel-feedback-list@...adcom.com>,
        "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] reset: brcmstb: Fix resource checks



On 10/31/2019 8:06 PM, Florian Fainelli wrote:
> The use of IS_ALIGNED() is incorrect, the typical resource we pass looks
> like this: start: 0x8404318, size: 0x30. When using IS_ALIGNED() we will
> get the following 0x8404318 & (0x18 - 1) = 0x10 which is definitively
> not equal to 0.
> 
> Replace this with an appropriate check on the start address and the
> resource size to be a multiple of SW_INIT_BANK_SIZE.
> 
> Fixes: 77750bc089e4 ("reset: Add Broadcom STB SW_INIT reset controller driver")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Sorry this fails building on 32-bit because it triggers a 64-bit
division let me go back and fix this...
-- 
Florian