linux-kernel - [PATCH] spi: cadence-quadpsi: fix platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191101151904.m2crt32kmn3gedba@4978f4969bb8>
Date:   Fri, 1 Nov 2019 23:19:04 +0800
From:   kbuild test robot <lkp@...el.com>
To:     "Ramuthevar,Vadivel MuruganX" 
        <vadivel.muruganx.ramuthevar@...ux.intel.com>
Cc:     kbuild-all@...ts.01.org, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org, broonie@...nel.org, vigneshr@...com,
        robh+dt@...nel.org, cheol.yong.kim@...el.com, qi-ming.wu@...el.com,
        Ramuthevar Vadivel Murugan 
        <vadivel.muruganx.ramuthevar@...ux.intel.com>
Subject: [PATCH] spi: cadence-quadpsi: fix platform_get_irq.cocci warnings

From: kbuild test robot <lkp@...el.com>

drivers/spi/spi-cadence-quadspi.c:1181:2-9: line 1181 is redundant because platform_get_irq() already prints an error

 Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: 61e865acd941 ("spi: cadence-quadpsi: Add support for the Cadence QSPI controller")
CC: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@...ux.intel.com>
Signed-off-by: kbuild test robot <lkp@...el.com>
---

url:    https://github.com/0day-ci/linux/commits/Ramuthevar-Vadivel-MuruganX/spi-cadence-quadpsi-Add-support-for-the-Cadence-QSPI-controller/20191101-174846
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Please take the patch only if it's a positive warning. Thanks!

 spi-cadence-quadspi.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/spi/spi-cadence-quadspi.c
+++ b/drivers/spi/spi-cadence-quadspi.c
@@ -1178,7 +1178,6 @@ static int cadence_qspi_probe(struct pla
 
 	cqspi->irq = platform_get_irq(pdev, 0);
 	if (cqspi->irq < 0) {
-		dev_err(dev, "platform_get_irq failed.\n");
 		ret = -ENXIO;
 		goto err_irq;
 	}