linux-kernel - Re: [PATCH v2 4/4] mtd: spi-nor: Add support for w25q256jw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191101160943.GA20347@Mani-XPS-13-9360>
Date:   Fri, 1 Nov 2019 21:39:43 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To:     Tudor.Ambarus@...rochip.com
Cc:     shawnguo@...nel.org, s.hauer@...gutronix.de, robh+dt@...nel.org,
        kernel@...gutronix.de, festevam@...il.com, linux-imx@....com,
        darshak.patel@...fochips.com, prajose.john@...fochips.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, marek.vasut@...il.com,
        dwmw2@...radead.org, computersforpeace@...il.com,
        miquel.raynal@...tlin.com, richard@....at, vigneshr@...com,
        linux-mtd@...ts.infradead.org
Subject: Re: [PATCH v2 4/4] mtd: spi-nor: Add support for w25q256jw

On Fri, Nov 01, 2019 at 03:55:01PM +0000, Tudor.Ambarus@...rochip.com wrote:
> 
> 
> On 11/01/2019 04:58 PM, Manivannan Sadhasivam wrote:
> >>> Add MTD support for w25q256jw SPI NOR chip from Winbond. This chip
> >>> supports dual/quad I/O mode with 512 blocks of memory organized in
> >>> 64KB sectors. In addition to this, there is also small 4KB sectors
> >>> available for flexibility. The device has been validated using Thor96
> >>> board.
> >>>
> >>> Cc: Marek Vasut <marek.vasut@...il.com>
> >>> Cc: Tudor Ambarus <tudor.ambarus@...rochip.com>
> >>> Cc: David Woodhouse <dwmw2@...radead.org>
> >>> Cc: Brian Norris <computersforpeace@...il.com>
> >>> Cc: Miquel Raynal <miquel.raynal@...tlin.com>
> >>> Cc: Richard Weinberger <richard@....at>
> >>> Cc: Vignesh Raghavendra <vigneshr@...com>
> >>> Cc: linux-mtd@...ts.infradead.org
> >>> Signed-off-by: Darshak Patel <darshak.patel@...fochips.com>
> >>> [Mani: cleaned up for upstream]
> >> Can we keep Darshak's authorship? We usually change the author if we feel that
> >> we made a significant change to what was originally published.
> >>
> >> If it's just about cosmetics, cleaning or rebase, you can specify what you did
> >> after the author's S-o-b tag and then add your S-o-b, as you did above.
> >>
> > I'd suggest to keep Darshak's authorship since he did the actual change in
> > the bsp. I have to clean it up before submitting upstream and I mentioned
> > the same above.
> > 
> 
> Ok, I'll amend the author when applying, it will be Darshak.
> 

Ah no. I was saying we should keep both of ours authorship. It shouldn't
be an issue because we both are involved in the process.

Thanks,
Mani

> Thanks,
> ta