linux-kernel - Re: [PATCH] [v2] crypto: inside-secure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191101053931.i7yoxhptrftu537m@gondor.apana.org.au>
Date:   Fri, 1 Nov 2019 13:39:31 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Antoine Tenart <antoine.tenart@...tlin.com>,
        "David S. Miller" <davem@...emloft.net>,
        Pascal van Leeuwen <pvanleeuwen@...imatrix.com>,
        Pascal van Leeuwen <pascalvanl@...il.com>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] crypto: inside-secure - Reduce stack usage

On Tue, Oct 22, 2019 at 05:14:13PM +0200, Arnd Bergmann wrote:
>
>  	case CONTEXT_CONTROL_CRYPTO_ALG_SM3:
>  		if (safexcel_hmac_setkey("safexcel-sm3", keys.authkey,
> -					 keys.authkeylen, &istate, &ostate))
> +					 keys.authkeylen, &state[0], &state[1]))
>  			goto badkey;

Any reason why this one remains as "goto badkey" instead of
badkey_free?

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt