linux-kernel - Re: [PATCH] staging: wfx: fix warning of using plain integer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191102103925.GA170933@kroah.com>
Date:   Sat, 2 Nov 2019 11:39:25 +0100
From:   Greg KH <greg@...ah.com>
To:     Jules Irenge <jbi.octave@...il.com>
Cc:     outreachy-kernel@...glegroups.com, jerome.pouiller@...abs.com,
        gregkh@...uxfoundation.com, Boqun.Feng@...rosoft.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: wfx: fix warning of using plain integer

On Sat, Nov 02, 2019 at 12:14:57AM +0000, Jules Irenge wrote:
> Fix warning of using plain integer as NULL pointer.
> Issue reported by sparse tool.
> 
> Signed-off-by: Jules Irenge <jbi.octave@...il.com>
> ---
>  drivers/staging/wfx/queue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wfx/queue.c b/drivers/staging/wfx/queue.c
> index ef3ee55cf621..5d29bce65f71 100644
> --- a/drivers/staging/wfx/queue.c
> +++ b/drivers/staging/wfx/queue.c
> @@ -565,7 +565,7 @@ struct hif_msg *wfx_tx_queues_get(struct wfx_dev *wdev)
>  		}
>  
>  		if (ret)
> -			return 0;
> +			return NULL;
>  
>  		queue_num = queue - wdev->tx_queue;
>  
> -- 
> 2.21.0
> 

Please send this as part of a patch series, with your other changes to
this driver.

thanks,

greg k-h