linux-kernel - Re: [PATCH] mm: There should have an unit (kB)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191102205411.GB15832@bombadil.infradead.org>
Date:   Sat, 2 Nov 2019 13:54:11 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     hui yang <yanghui.def@...il.com>
Cc:     akpm@...ux-foundation.org, mhocko@...e.com,
        dan.j.williams@...el.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: There should have an unit (kB)

On Sat, Nov 02, 2019 at 10:18:07PM +0800, hui yang wrote:
> From: YangHui <yanghui.def@...il.com>
> 
> -    printk(KERN_CONT " %ld", zone->lowmem_reserve[i]);
> +    printk(KERN_CONT " %ldkB", zone->lowmem_reserve[i]);
> Make it look more perfect

I don't think this is accounted in kilobytes though.  Isn't it the
number of pages?