linux-kernel - Re: [PATCH v3] x86: Add trace points to (nearly) all vectors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201911020848.LOEtnDnd%lkp@intel.com>
Date:   Sat, 2 Nov 2019 08:47:59 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Andi Kleen <andi@...stfloor.org>
Cc:     kbuild-all@...ts.01.org, x86@...nel.org,
        linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH v3] x86: Add trace points to (nearly) all vectors

Hi Andi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/auto-latest]
[also build test ERROR on v5.4-rc5 next-20191031]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Andi-Kleen/x86-Add-trace-points-to-nearly-all-vectors/20191102-063457
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git a5b576bfb3ba85d3e356f9900dce1428d4760582
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   arch/x86/kernel/traps.c: In function 'do_error_trap':
>> arch/x86/kernel/traps.c:264:2: error: implicit declaration of function 'trace_other_vector_entry'; did you mean 'frame_vector_destroy'? [-Werror=implicit-function-declaration]
     trace_other_vector_entry(trapnr);
     ^~~~~~~~~~~~~~~~~~~~~~~~
     frame_vector_destroy
>> arch/x86/kernel/traps.c:279:2: error: implicit declaration of function 'trace_other_vector_exit'; did you mean 'trace_hardirq_exit'? [-Werror=implicit-function-declaration]
     trace_other_vector_exit(trapnr);
     ^~~~~~~~~~~~~~~~~~~~~~~
     trace_hardirq_exit
   cc1: some warnings being treated as errors
--
   arch/x86/kernel/irq.c: In function 'smp_kvm_posted_intr_ipi':
>> arch/x86/kernel/irq.c:311:2: error: implicit declaration of function 'trace_other_vector_entry'; did you mean 'frame_vector_destroy'? [-Werror=implicit-function-declaration]
     trace_other_vector_entry(POSTED_INTR_VECTOR);
     ^~~~~~~~~~~~~~~~~~~~~~~~
     frame_vector_destroy
>> arch/x86/kernel/irq.c:314:2: error: implicit declaration of function 'trace_other_vector_exit'; did you mean 'trace_hardirq_exit'? [-Werror=implicit-function-declaration]
     trace_other_vector_exit(POSTED_INTR_VECTOR);
     ^~~~~~~~~~~~~~~~~~~~~~~
     trace_hardirq_exit
   cc1: some warnings being treated as errors

vim +264 arch/x86/kernel/traps.c

   259	
   260	static void do_error_trap(struct pt_regs *regs, long error_code, char *str,
   261		unsigned long trapnr, int signr, int sicode, void __user *addr)
   262	{
   263		RCU_LOCKDEP_WARN(!rcu_is_watching(), "entry code didn't wake RCU");
 > 264		trace_other_vector_entry(trapnr);
   265	
   266		/*
   267		 * WARN*()s end up here; fix them up before we call the
   268		 * notifier chain.
   269		 */
   270		if (!user_mode(regs) && fixup_bug(regs, trapnr))
   271			goto out;
   272	
   273		if (notify_die(DIE_TRAP, str, regs, error_code, trapnr, signr) !=
   274				NOTIFY_STOP) {
   275			cond_local_irq_enable(regs);
   276			do_trap(trapnr, signr, str, regs, error_code, sicode, addr);
   277		}
   278	out:
 > 279		trace_other_vector_exit(trapnr);
   280	}
   281	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (7209 bytes)