linux-kernel - Re: cdrom: make debug logging rely on pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191103160030.GO1384@kitsune.suse.cz>
Date:   Sun, 3 Nov 2019 17:00:30 +0100
From:   Michal Suchánek <msuchanek@...e.de>
To:     flameeyes@...meeyes.com
Cc:     axboe@...nel.dk, linux-kernel@...r.kernel.org
Subject: Re: cdrom: make debug logging rely on pr_debug and debugfs only.

Hello,

can you change cd_dbg to a macro that always prints the device name
using pr_debug instead of removing it?

That way you will get much more useful debug messages. That's also what
many other subsystems do.

Also consider adding some relevant mailinglist to cc. I think the
MAINTAINERS even specifies linux-scsi for cdrom and/or sr.

Thanks

Michal