linux-kernel - Re: [PATCH 2/2] power/supply: Add generic USB charger driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201911040607.oYqvDzXW%lkp@intel.com>
Date:   Mon, 4 Nov 2019 06:52:36 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     kbuild-all@...ts.01.org, Sebastian Reichel <sre@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        od@...c.me, Paul Cercueil <paul@...pouillou.net>
Subject: Re: [PATCH 2/2] power/supply: Add generic USB charger driver

Hi Paul,

I love your patch! Yet something to improve:

[auto build test ERROR on power-supply/for-next]
[cannot apply to v5.4-rc6 next-20191031]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Paul-Cercueil/dt-bindings-power-supply-Document-generic-USB-charger/20191104-061214
base:   https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

>> drivers/power/supply/generic-usb-charger.c:131:21: error: implicit declaration of function 'of_match_ptr'; did you mean 'usb_match_id'? [-Werror=implicit-function-declaration]
      .of_match_table = of_match_ptr(usb_charger_of_match),
                        ^~~~~~~~~~~~
                        usb_match_id
>> drivers/power/supply/generic-usb-charger.c:131:21: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
   drivers/power/supply/generic-usb-charger.c:131:21: note: (near initialization for 'usb_charger_driver.driver.of_match_table')
>> drivers/power/supply/generic-usb-charger.c:131:21: error: initializer element is not constant
   drivers/power/supply/generic-usb-charger.c:131:21: note: (near initialization for 'usb_charger_driver.driver.of_match_table')
   cc1: some warnings being treated as errors

vim +131 drivers/power/supply/generic-usb-charger.c

   127	
   128	static struct platform_driver usb_charger_driver = {
   129		.driver = {
   130			.name = "usb-charger",
 > 131			.of_match_table = of_match_ptr(usb_charger_of_match),
   132		},
   133		.probe = usb_charger_probe,
   134		.remove = usb_charger_remove,
   135	};
   136	module_platform_driver(usb_charger_driver);
   137	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (52250 bytes)