linux-kernel - Re: [PATCH 04/14] soundwire: bus_type: rename sdw_drv_ to sdw_slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191103053003.GH2695@vkoul-mobl.Dlink>
Date:   Sun, 3 Nov 2019 11:00:03 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        tiwai@...e.de, broonie@...nel.org, gregkh@...uxfoundation.org,
        jank@...ence.com, srinivas.kandagatla@...aro.org,
        slawomir.blauciak@...el.com,
        Bard liao <yung-chuan.liao@...ux.intel.com>,
        Rander Wang <rander.wang@...ux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Sanyog Kale <sanyog.r.kale@...el.com>
Subject: Re: [PATCH 04/14] soundwire: bus_type: rename sdw_drv_ to
 sdw_slave_drv

On 23-10-19, 16:28, Pierre-Louis Bossart wrote:
> Before we add master driver support, make sure there is no ambiguity
> and no occirrences of sdw_drv_ functions.
        ^^^^^^^^^^^
typo

> 
> No functionality change.
> 
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
> ---
>  drivers/soundwire/bus_type.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c
> index 2b2830b622fa..9a0fd3ee1014 100644
> --- a/drivers/soundwire/bus_type.c
> +++ b/drivers/soundwire/bus_type.c
> @@ -67,7 +67,7 @@ struct bus_type sdw_bus_type = {
>  };
>  EXPORT_SYMBOL_GPL(sdw_bus_type);
>  
> -static int sdw_drv_probe(struct device *dev)
> +static int sdw_slave_drv_probe(struct device *dev)
>  {
>  	struct sdw_slave *slave = to_sdw_slave_device(dev);
>  	struct sdw_driver *drv = to_sdw_slave_driver(dev->driver);
> @@ -113,7 +113,7 @@ static int sdw_drv_probe(struct device *dev)
>  	return 0;
>  }
>  
> -static int sdw_drv_remove(struct device *dev)
> +static int sdw_slave_drv_remove(struct device *dev)
>  {
>  	struct sdw_slave *slave = to_sdw_slave_device(dev);
>  	struct sdw_driver *drv = to_sdw_slave_driver(dev->driver);
> @@ -127,7 +127,7 @@ static int sdw_drv_remove(struct device *dev)
>  	return ret;
>  }
>  
> -static void sdw_drv_shutdown(struct device *dev)
> +static void sdw_slave_drv_shutdown(struct device *dev)
>  {
>  	struct sdw_slave *slave = to_sdw_slave_device(dev);
>  	struct sdw_driver *drv = to_sdw_slave_driver(dev->driver);
> @@ -155,13 +155,13 @@ int __sdw_register_slave_driver(struct sdw_driver *drv,
>  	}
>  
>  	drv->driver.owner = owner;
> -	drv->driver.probe = sdw_drv_probe;
> +	drv->driver.probe = sdw_slave_drv_probe;
>  
>  	if (drv->remove)
> -		drv->driver.remove = sdw_drv_remove;
> +		drv->driver.remove = sdw_slave_drv_remove;
>  
>  	if (drv->shutdown)
> -		drv->driver.shutdown = sdw_drv_shutdown;
> +		drv->driver.shutdown = sdw_slave_drv_shutdown;
>  
>  	return driver_register(&drv->driver);
>  }
> -- 
> 2.20.1

-- 
~Vinod