linux-kernel - Re: [PATCH 03/10] iio: imu: adis16460: check ret val for non-zero vs less-than-zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191103102524.2b5e05cc@archlinux>
Date:   Sun, 3 Nov 2019 10:25:24 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>
Cc:     <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <lars@...afoo.de>, <Michael.Hennerich@...log.com>,
        <dragos.bogdan@...log.com>
Subject: Re: [PATCH 03/10] iio: imu: adis16460: check ret val for non-zero
 vs less-than-zero

On Fri, 1 Nov 2019 11:34:58 +0200
Alexandru Ardelean <alexandru.ardelean@...log.com> wrote:

> The ADIS library functions return zero on success, and negative values for
> error. Positive values aren't returned, but we only care about the success
> value (which is zero).
> 
> This change is mostly needed so that the compiler won't make any inferences
> about some about values being potentially un-initialized. This only
> triggers after making some functions inline, because the compiler can
> better follow return paths.
> 
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com>
Applied thanks.

Jonathan

> ---
>  drivers/iio/imu/adis16460.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/imu/adis16460.c b/drivers/iio/imu/adis16460.c
> index 6aed9e84abbf..b55812521537 100644
> --- a/drivers/iio/imu/adis16460.c
> +++ b/drivers/iio/imu/adis16460.c
> @@ -80,7 +80,7 @@ static int adis16460_show_serial_number(void *arg, u64 *val)
>  
>  	ret = adis_read_reg_16(&adis16460->adis, ADIS16460_REG_SERIAL_NUM,
>  		&serial);
> -	if (ret < 0)
> +	if (ret)
>  		return ret;
>  
>  	*val = serial;
> @@ -98,7 +98,7 @@ static int adis16460_show_product_id(void *arg, u64 *val)
>  
>  	ret = adis_read_reg_16(&adis16460->adis, ADIS16460_REG_PROD_ID,
>  		&prod_id);
> -	if (ret < 0)
> +	if (ret)
>  		return ret;
>  
>  	*val = prod_id;
> @@ -116,7 +116,7 @@ static int adis16460_show_flash_count(void *arg, u64 *val)
>  
>  	ret = adis_read_reg_32(&adis16460->adis, ADIS16460_REG_FLASH_CNT,
>  		&flash_count);
> -	if (ret < 0)
> +	if (ret)
>  		return ret;
>  
>  	*val = flash_count;
> @@ -176,7 +176,7 @@ static int adis16460_get_freq(struct iio_dev *indio_dev, int *val, int *val2)
>  	unsigned int freq;
>  
>  	ret = adis_read_reg_16(&st->adis, ADIS16460_REG_DEC_RATE, &t);
> -	if (ret < 0)
> +	if (ret)
>  		return ret;
>  
>  	freq = 2048000 / (t + 1);