[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <31815641-550c-88ab-c037-2e743cea59b3@xs4all.nl>
Date: Mon, 4 Nov 2019 10:41:20 +0100
From: Hans Verkuil <hverkuil-cisco@...all.nl>
To: Ricardo Ribalda Delgado <ribalda@...nel.org>,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] v4l2-ctl: Support setting V4L2_CTRL_TYPE_AREA
controls
On 11/1/19 12:25 PM, Ricardo Ribalda Delgado wrote:
> $ v4l2-ctl -d /dev/video1 -c area=123123x233
>
> Signed-off-by: Ricardo Ribalda Delgado <ribalda@...nel.org>
> ---
> utils/v4l2-ctl/v4l2-ctl-common.cpp | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/utils/v4l2-ctl/v4l2-ctl-common.cpp b/utils/v4l2-ctl/v4l2-ctl-common.cpp
> index 95339561..676b05e0 100644
> --- a/utils/v4l2-ctl/v4l2-ctl-common.cpp
> +++ b/utils/v4l2-ctl/v4l2-ctl-common.cpp
> @@ -973,6 +973,10 @@ void common_set(cv4l_fd &_fd)
> strncpy(ctrl.string, iter->second.c_str(), qc.maximum);
> ctrl.string[qc.maximum] = 0;
> break;
> + case V4L2_CTRL_TYPE_AREA:
> + sscanf(iter->second.c_str(), "%dx%d",
Use %ux%u since these are unsigned values.
Regards,
Hans
> + &ctrl.p_area->width, &ctrl.p_area->height);
> + break;
> default:
> fprintf(stderr, "%s: unsupported payload type\n",
> qc.name);
>
Powered by blists - more mailing lists