linux-kernel - [RFC PATCH 3/3] platform/x86: asus_wmi: Set default fan boost mode to normal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPW-Pu3a7UjhW3wZ7jMLMEwj5goabqgHp2Vf7tQyzT3XwZr8cg@mail.gmail.com>
Date:   Mon, 4 Nov 2019 12:55:44 +0200
From:   Leon Maxx <leonmaxx@...il.com>
To:     linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        acpi4asus-user@...ts.sourceforge.net, andy@...radead.org,
        dvhart@...radead.org, corentin.chary@...il.com,
        Daniel Drake <drake@...lessm.com>, yurii.pavlovskyi@...il.com
Subject: [RFC PATCH 3/3] platform/x86: asus_wmi: Set default fan boost mode to normal

Set default fan boost mode to normal for multiple reasons:

1) existing code assumes that laptop started in normal mode and that is
not always true.
2) FX705DY/FX505DY starts in silent mode and under heavy CPU load it
overheats and drops CPU frequency to 399MHz [1]. Setting fan mode to
normal avoids overheating.

[1] Link: https://bugzilla.kernel.org/show_bug.cgi?id=203733

Signed-off-by: Leonid Maksymchuk <leonmaxx@...il.com>
---
 drivers/platform/x86/asus-wmi.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index f4e5840..70c5fbb 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -1674,6 +1674,18 @@ static int fan_boost_mode_write(struct asus_wmi *asus)
  return 0;
 }

+static int fan_boost_mode_set_default(struct asus_wmi *asus)
+{
+ int result = 0;
+
+ if (asus->fan_boost_mode_available) {
+ asus->fan_boost_mode = ASUS_FAN_BOOST_MODE_NORMAL;
+ result = fan_boost_mode_write(asus);
+ }
+
+ return result;
+}
+
 static int fan_boost_mode_switch_next(struct asus_wmi *asus)
 {
  u8 mask = asus->fan_boost_mode_mask;
@@ -2450,6 +2462,7 @@ static int asus_wmi_add(struct platform_device *pdev)
  err = fan_boost_mode_check_present(asus);
  if (err)
  goto fail_fan_boost_mode;
+ fan_boost_mode_set_default(asus);

  err = asus_wmi_sysfs_init(asus->platform_device);
  if (err)
-- 
1.8.3.1