linux-kernel - Re: [PATCH v5 03/12] clk: mediatek: mt8173: switch mmsys to platform device probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <35f31784-6703-435a-2675-95bea33adf35@suse.com>
Date:   Mon, 4 Nov 2019 12:14:10 +0100
From:   Matthias Brugger <mbrugger@...e.com>
To:     Hsin-Yi Wang <hsinyi@...omium.org>, matthias.bgg@...nel.org
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        CK Hu <ck.hu@...iatek.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        David Airlie <airlied@...ux.ie>, mturquette@...libre.com,
        sboyd@...eaurora.org, ulrich.hecht+renesas@...il.com,
        laurent.pinchart@...asonboard.com,
        Matthias Brugger <matthias.bgg@...il.com>,
        Devicetree List <devicetree@...r.kernel.org>,
        rdunlap@...radead.org, sean.wang@...iatek.com,
        lkml <linux-kernel@...r.kernel.org>,
        dri-devel@...ts.freedesktop.org, sean.wang@...nel.org,
        wens@...e.org, linux-mediatek@...ts.infradead.org,
        linux-clk@...r.kernel.org,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v5 03/12] clk: mediatek: mt8173: switch mmsys to platform
 device probing



On 31/10/2019 05:17, Hsin-Yi Wang wrote:
> On Fri, Nov 16, 2018 at 12:54 PM <matthias.bgg@...nel.org> wrote:
>>
>> From: Matthias Brugger <mbrugger@...e.com>
>>
>> Switch probing for the MMSYS to support invocation to a
>> plain paltform device. The driver will be probed by the DRM subsystem.
>>
>> Signed-off-by: Matthias Brugger <mbrugger@...e.com>
>> ---
> 
>> +
>> +static struct platform_driver clk_mt8173_mm_drv = {
>> +       .probe = mtk_mmsys_probe,
>> +       .probe = mtk_mmsys_remove,
> Should be .remove?
> 

Yes, definitely.

>> +       .driver = {
>> +               .name = "clk-mt8173-mm",
>> +       },
>> +};
>> +module_platform_driver(clk_mt8173_mm_drv);
>>
>>  static void __init mtk_vdecsys_init(struct device_node *node)
>>  {