[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191104082538.292b501a@grimm.local.home>
Date: Mon, 4 Nov 2019 08:25:38 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Mark Rutland <mark.rutland@....com>
Cc: linux-arm-kernel@...ts.infradead.org, Jessica Yu <jeyu@...nel.org>,
Helge Deller <deller@....de>,
"James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
linux-kernel@...r.kernel.org, amit.kachhap@....com,
catalin.marinas@....com, duwe@...e.de, james.morse@....com,
jpoimboe@...hat.com, jthierry@...hat.com,
linux-parisc@...r.kernel.org, mingo@...hat.com,
peterz@...radead.org, svens@...ckframe.org,
takahiro.akashi@...aro.org, will@...nel.org
Subject: Re: [PATCHv2 2/8] module/ftrace: handle patchable-function-entry
On Tue, 29 Oct 2019 16:58:26 +0000
Mark Rutland <mark.rutland@....com> wrote:
> When using patchable-function-entry, the compiler will record the
> callsites into a section named "__patchable_function_entries" rather
> than "__mcount_loc". Let's abstract this difference behind a new
> FTRACE_CALLSITE_SECTION, so that architectures don't have to handle this
> explicitly (e.g. with custom module linker scripts).
>
> As parisc currently handles this explicitly, it is fixed up accordingly,
> with its custom linker script removed. Since FTRACE_CALLSITE_SECTION is
> only defined when DYNAMIC_FTRACE is selected, the parisc module loading
> code is updated to only use the definition in that case. When
> DYNAMIC_FTRACE is not selected, modules shouldn't have this section, so
> this removes some redundant work in that case.
>
> I built parisc generic-{32,64}bit_defconfig with DYNAMIC_FTRACE enabled,
> and verified that the section made it into the .ko files for modules.
>
> Signed-off-by: Mark Rutland <mark.rutland@....com>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> Cc: Helge Deller <deller@....de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: James E.J. Bottomley <James.Bottomley@...senPartnership.com>
> Cc: Jessica Yu <jeyu@...nel.org>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Sven Schnelle <svens@...ckframe.org>
> Cc: linux-parisc@...r.kernel.org
>
Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
-- Steve
Powered by blists - more mailing lists