linux-kernel - Re: [PATCH v5 7/7] perf report: Sort by sampled cycles percent per block for tui

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191104135333.GH8251@krava>
Date:   Mon, 4 Nov 2019 14:53:33 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     "Jin, Yao" <yao.jin@...ux.intel.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v5 7/7] perf report: Sort by sampled cycles percent per
 block for tui

On Fri, Nov 01, 2019 at 10:07:33PM +0800, Jin, Yao wrote:
> 
> 
> On 11/1/2019 4:34 PM, Jiri Olsa wrote:
> > On Wed, Oct 30, 2019 at 02:04:30PM +0800, Jin Yao wrote:
> > 
> > SNIP
> > 
> > > diff --git a/tools/perf/ui/browsers/hists.h b/tools/perf/ui/browsers/hists.h
> > > index 91d3e18b50aa..078f2f2c7abd 100644
> > > --- a/tools/perf/ui/browsers/hists.h
> > > +++ b/tools/perf/ui/browsers/hists.h
> > > @@ -5,6 +5,7 @@
> > >   #include "ui/browser.h"
> > >   struct annotation_options;
> > > +struct evsel;
> > >   struct hist_browser {
> > >   	struct ui_browser   b;
> > > @@ -15,6 +16,7 @@ struct hist_browser {
> > >   	struct pstack	    *pstack;
> > >   	struct perf_env	    *env;
> > >   	struct annotation_options *annotation_opts;
> > > +	struct evsel	    *block_evsel;
> > 
> > you should be able to get the evsel from hists_to_evsel function
> > 
> > jirka
> > 
> 
> Maybe we can't. The hists in hist_browser is set to block_hists (not the
> hists for evsel).
> 
> See block_hists_tui_browse,
> 
> int block_hists_tui_browse(struct block_hist *bh, struct evsel *evsel,
>                           float min_percent)
> {
>        struct hists *hists = &bh->block_hists;
>        struct hist_browser *browser;
>        ......
>        browser = hist_browser__new(hists);
>        ......
> }
> 
> So I have to pass the evsel in.

I see, ok

jirka