[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191104085901.06035a26@grimm.local.home>
Date: Mon, 4 Nov 2019 08:59:01 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Tejun Heo <tj@...nel.org>, Johannes Weiner <hannes@...xchg.org>,
Li Zefan <lizefan@...wei.com>,
LKML <linux-kernel@...r.kernel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Song Liu <liu.song.a23@...il.com>, cgroups@...r.kernel.org,
Ingo Molnar <mingo@...hat.com>,
Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Martin KaFai Lau <kafai@...com>,
Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
Jens Axboe <axboe@...nel.dk>,
"David S. Miller" <davem@...emloft.net>,
linux-block@...r.kernel.org, bpf@...r.kernel.org,
netdev@...r.kernel.org
Subject: Re: [PATCH v2 1/2] kernfs: Convert to u64 id
On Mon, 4 Nov 2019 17:45:19 +0900
Namhyung Kim <namhyung@...nel.org> wrote:
> From: Tejun Heo <tj@...nel.org>
>
> The kernfs_id was an union type sharing a 64bit id with 32bit ino +
> gen. But it resulted in using 32bit inode even on 64bit systems.
> Also dealing with an union is annoying especially if you just want to
> use a single id.
>
> Thus let's get rid of the kernfs_node_id type and use u64 directly.
> The upper 32bit is used for gen and lower is for ino on 32bit systems.
> The kernfs_id_ino() and kernfs_id_gen() helpers will take care of the
> bit handling depends on the system word size.
>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Alexei Starovoitov <ast@...nel.org>
> Cc: Daniel Borkmann <daniel@...earbox.net>
> Cc: Martin KaFai Lau <kafai@...com>
> Cc: Song Liu <songliubraving@...com>
> Cc: Yonghong Song <yhs@...com>
> Cc: Jens Axboe <axboe@...nel.dk>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: linux-block@...r.kernel.org
> Cc: bpf@...r.kernel.org
> Cc: netdev@...r.kernel.org
> Signed-off-by: Tejun Heo <tj@...nel.org>
> [namhyung: fix build error in bpf_get_current_cgroup_id()]
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
> fs/kernfs/dir.c | 36 ++++++++-----
> fs/kernfs/file.c | 4 +-
> fs/kernfs/inode.c | 4 +-
> fs/kernfs/kernfs-internal.h | 2 -
> fs/kernfs/mount.c | 92 +++++++++++++++++++-------------
> include/linux/cgroup.h | 17 +++---
> include/linux/exportfs.h | 5 ++
> include/linux/kernfs.h | 47 +++++++++-------
> include/trace/events/writeback.h | 92 ++++++++++++++++----------------
I only looked at the above file, and didn't see anything bad about it.
Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
-- Steve
> kernel/bpf/helpers.c | 2 +-
> kernel/cgroup/cgroup.c | 5 +-
> kernel/trace/blktrace.c | 66 +++++++++++------------
> net/core/filter.c | 4 +-
> 13 files changed, 207 insertions(+), 169 deletions(-)
Powered by blists - more mailing lists