linux-kernel - [PATCH] phy: cadence: sierra: add missed clk_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20191104150102.6424-1-hslester96@gmail.com>
Date:   Mon,  4 Nov 2019 23:01:02 +0800
From:   Chuhong Yuan <hslester96@...il.com>
To:     unlisted-recipients:; (no To-header on input)
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        linux-kernel@...r.kernel.org, Chuhong Yuan <hslester96@...il.com>
Subject: [PATCH] phy: cadence: sierra: add missed clk_disable_unprepare in remove

The driver forgets to disable and unprepare clk when remove.
Add a call to clk_disable_unprepare to fix it.

Signed-off-by: Chuhong Yuan <hslester96@...il.com>
---
 drivers/phy/cadence/phy-cadence-sierra.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c
index de10402f2931..81a987ca54a5 100644
--- a/drivers/phy/cadence/phy-cadence-sierra.c
+++ b/drivers/phy/cadence/phy-cadence-sierra.c
@@ -291,6 +291,7 @@ static int cdns_sierra_phy_remove(struct platform_device *pdev)
 	struct cdns_sierra_phy *phy = dev_get_drvdata(pdev->dev.parent);
 	int i;
 
+	clk_disable_unprepare(phy->clk);
 	reset_control_assert(phy->phy_rst);
 	reset_control_assert(phy->apb_rst);
 	pm_runtime_disable(&pdev->dev);
-- 
2.23.0