linux-kernel - Re: [PATCH] pinctrl: amd: fix __iomem annotation in amd_gpio_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 4 Nov 2019 16:08:45 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     "Ben Dooks (Codethink)" <ben.dooks@...ethink.co.uk>
Cc:     linux-kernel@...ts.codethink.co.uk,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: amd: fix __iomem annotation in amd_gpio_irq_handler()

On Tue, Oct 22, 2019 at 5:11 PM Ben Dooks (Codethink)
<ben.dooks@...ethink.co.uk> wrote:

> The regs pointer in amd_gpio_irq_handler() should have __iomem
> on it, so add that to fix the following sparse warnings:
>
> drivers/pinctrl/pinctrl-amd.c:555:14: warning: incorrect type in assignment (different address spaces)
> drivers/pinctrl/pinctrl-amd.c:555:14:    expected unsigned int [usertype] *regs
> drivers/pinctrl/pinctrl-amd.c:555:14:    got void [noderef] <asn:2> *base
> drivers/pinctrl/pinctrl-amd.c:563:34: warning: incorrect type in argument 1 (different address spaces)
> drivers/pinctrl/pinctrl-amd.c:563:34:    expected void const volatile [noderef] <asn:2> *addr
> drivers/pinctrl/pinctrl-amd.c:563:34:    got unsigned int [usertype] *
> drivers/pinctrl/pinctrl-amd.c:580:34: warning: incorrect type in argument 1 (different address spaces)
> drivers/pinctrl/pinctrl-amd.c:580:34:    expected void const volatile [noderef] <asn:2> *addr
> drivers/pinctrl/pinctrl-amd.c:580:34:    got unsigned int [usertype] *
> drivers/pinctrl/pinctrl-amd.c:587:25: warning: incorrect type in argument 2 (different address spaces)
> drivers/pinctrl/pinctrl-amd.c:587:25:    expected void volatile [noderef] <asn:2> *addr
> drivers/pinctrl/pinctrl-amd.c:587:25:    got unsigned int [usertype] *
>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@...ethink.co.uk>
> ---
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: linux-gpio@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org

Patch applied.

Yours,
Linus Walleij