linux-kernel - Re: linusw/devel boot bisection: v5.4-rc1-31-g6a41b6c5fc20 on rk3399-puma-haikou

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa0ca588-a034-1f00-8492-a3f574a5b24b@collabora.com>
Date:   Mon, 4 Nov 2019 15:22:00 +0000
From:   Guillaume Tucker <guillaume.tucker@...labora.com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Chris Packham <Chris.Packham@...iedtelesis.co.nz>
Cc:     "scott.branden@...adcom.com" <scott.branden@...adcom.com>,
        "enric.balletbo@...labora.com" <enric.balletbo@...labora.com>,
        "tomeu.vizoso@...labora.com" <tomeu.vizoso@...labora.com>,
        "mgalka@...labora.com" <mgalka@...labora.com>,
        "matthew.hart@...aro.org" <matthew.hart@...aro.org>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "bot@...nelci.org" <bot@...nelci.org>,
        "khilman@...libre.com" <khilman@...libre.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "bcm-kernel-feedback-list@...adcom.com" 
        <bcm-kernel-feedback-list@...adcom.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "sbranden@...adcom.com" <sbranden@...adcom.com>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "rjui@...adcom.com" <rjui@...adcom.com>
Subject: Re: linusw/devel boot bisection: v5.4-rc1-31-g6a41b6c5fc20 on
 rk3399-puma-haikou

On 04/11/2019 15:18, Linus Walleij wrote:
> On Thu, Oct 31, 2019 at 8:35 PM Chris Packham
> <Chris.Packham@...iedtelesis.co.nz> wrote:
>> On Thu, 2019-10-31 at 11:41 -0700, kernelci.org bot wrote:
> 
>>> Breaking commit found:
>>>
>>> -------------------------------------------------------------------------------
>>> commit 6a41b6c5fc20abced88fa0eed42ae5e5cb70b280
>>> Author: Chris Packham <chris.packham@...iedtelesis.co.nz>
>>> Date:   Fri Oct 25 09:27:03 2019 +1300
>>>
>>>     gpio: Add xgs-iproc driver
>>>
>>>     This driver supports the Chip Common A GPIO controller present on a
>>>     number of Broadcom switch ASICs with integrated SoCs. The controller is
>>>     similar to the pinctrl-nsp-gpio and pinctrl-iproc-gpio blocks but
>>>     different enough that a separate driver is required.
>>>
>>>     This has been ported from Broadcom's XLDK 5.0.3 retaining only the CCA
>>>     support (pinctrl-iproc-gpio covers CCB).
>>>
>>>     Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
>>>     Link: https://lore.kernel.org/r/20191024202703.8017-3-chris.packham@alliedtelesis.co.nz
>>>     Acked-by: Scott Branden <scott.branden@...adcom.com>
>>>     Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
>>
>> Hmm,
>>
>> I don't see how this commit would have caused the oops. The new driver
>> shouldn't (and doesn't appear to be) run on any platform as nothing
>> declares .compatible = "brcm,iproc-gpio-cca" (yet).
> 
> I think it looks really bogus as well.
> 
> Could it be that these systems are memory constrained such that
> the kernel image just exactly right now collides with the upper
> memory limit or corrupts its own ramdisk?
> 
> I suppose I can't ask the kernel robot to do any more detailed
> debugging.
> 
> I can't see any problem with this patch.

Yes it's possible that this patch increases the kernel image size
above a threshold that causes the board to fail to boot.  However
that board isn't in the Collabora lab so I don't have direct
access to it.  I'll see what we can do to debug this, will
disable bisections in lab-theobrama-systems for now to avoid more
noise.

Guillaume