linux-kernel - Re: [PATCH] nvme: change nvme_passthru

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191104153249.GC26808@redsun51.ssa.fujisawa.hgst.com>
Date:   Tue, 5 Nov 2019 00:32:49 +0900
From:   Keith Busch <kbusch@...nel.org>
To:     Christoph Hellwig <hch@....de>
Cc:     Marta Rybczynska <mrybczyn@...ray.eu>,
        Charles Machalow <csm10495@...il.com>,
        linux-nvme <linux-nvme@...ts.infradead.org>,
        axboe <axboe@...com>, Sagi Grimberg <sagi@...mberg.me>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvme: change nvme_passthru_cmd64's result field.

On Mon, Nov 04, 2019 at 04:29:16PM +0100, Christoph Hellwig wrote:
> 
> Except on 32-bit x86, which does not have the padding.  Which is why
> the current layout is so bad, as it breaks 32-it x86 compat.

Yeah, fair enough.

Charles, let's just define an explicit padding rsvd field and use the
appropriate struct for the different ioctl's.