linux-kernel - Re: [PATCH v2 VKMS 0/2] drm/vkms: Changing some words in 'blend' function documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 4 Nov 2019 10:50:13 -0500
From:   Rodrigo Siqueira <rodrigosiqueiramelo@...il.com>
To:     Gabriela Bittencourt <gabrielabittencourt00@...il.com>
Cc:     outreachy-kernel@...glegroups.com, manasi.d.navare@...el.com,
        hamohammed.sa@...il.com, daniel@...ll.ch, airlied@...ux.ie,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        lkcamp@...ts.libreplanetbr.org, trivial@...nel.org
Subject: Re: [PATCH v2 VKMS 0/2] drm/vkms: Changing some words in 'blend'
 function documentation

Hi Gabriela,

In the case of this series and the patch "drm/vkms: Fix typo in function
documentation", I recommend you to use a single patch. In general, If
your changes produce a lot of deltas, you need to split them into
individual patches that modify things in logical stages. In these
patches, you made changes to some files that belong to the same patch;
thus, a single logical change is contained within a single patch.[1]

Btw, thanks for fix these issues.

Best Regards

1. https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#separate-your-changes

On 11/01, Gabriela Bittencourt wrote:
> Changes in v2:
> - Add fixing typo in word 'destination'
> - Add change of the preposition
> - In v1 the name of the function was wrong, fix it in this version
> - Add the patch changing the word 'TODO'
> 
> I've tested the patches using kernel-doc
> 
> Gabriela Bittencourt (2):
>   drm/vkms: Fix typo and preposion in function documentation
>   drm/vkms: Changing a 'Todo' to a 'TODO' in code comment
> 
>  drivers/gpu/drm/vkms/vkms_composer.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> -- 
> 2.20.1
> 

-- 
Rodrigo Siqueira
Software Engineer, Advanced Micro Devices (AMD)
https://siqueira.tech

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)