[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191104164653.GA2281588@kroah.com>
Date: Mon, 4 Nov 2019 17:46:53 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Jules Irenge <jbi.octave@...il.com>
Cc: outreachy-kernel@...glegroups.com, devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org, abbotti@....co.uk
Subject: Re: [PATCH v2] staging: comedi: rewrite macro function with GNU
extension typeof
On Mon, Nov 04, 2019 at 04:33:31PM +0000, Jules Irenge wrote:
> Rewrite macro function with the GNU extension typeof
> to remove a possible side-effects of MACRO argument reuse "x".
> - Problem could rise if arguments have different types
> and different use though.
You can not just get away with a potential problem by documenting it :)
You might have just broken this. Why are you trying to "fix" something
that is not broken?
What is wrong with the code as-is?
thanks,
greg k-h
Powered by blists - more mailing lists