linux-kernel - Re: [PATCH] rtc: brcmstb-waketimer: add missed clk_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <420cbb31-1754-444c-cbc2-d32d77e43ca0@gmail.com>
Date:   Mon, 4 Nov 2019 09:36:11 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Chuhong Yuan <hslester96@...il.com>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        bcm-kernel-feedback-list@...adcom.com, linux-rtc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: brcmstb-waketimer: add missed clk_disable_unprepare

On 11/4/19 7:50 AM, Chuhong Yuan wrote:
> This driver forgets to disable and unprepare clock when remove.
> Add a call to clk_disable_unprepare to fix it.
> 
> Signed-off-by: Chuhong Yuan <hslester96@...il.com>

This looks fine, you do not need to check for timer->clk, since the
clk_* APIs do that, and we made sure in the probe function that we would
not be passing a timer->clk handle which is valid.

Also feel free to add:

Fixes: c4f07ecee22e ("rtc: brcmstb-waketimer: Add Broadcom STB wake-timer")

Thank you
-- 
Florian