linux-kernel - Re: [PATCH v2] drm: sun4i: Add support for suspending the display driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191104174218.GL10326@phenom.ffwll.local>
Date:   Mon, 4 Nov 2019 18:42:18 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Ondrej Jirman <megous@...ous.com>
Cc:     linux-sunxi@...glegroups.com, Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>, David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        "open list:DRM DRIVERS FOR ALLWINNER A10" 
        <dri-devel@...ts.freedesktop.org>,
        "moderated list:ARM/Allwinner sunXi SoC support" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] drm: sun4i: Add support for suspending the display
 driver

On Tue, Oct 29, 2019 at 12:28:46PM +0100, Ondrej Jirman wrote:
> Shut down the display engine during suspend.
> 
> Signed-off-by: Ondrej Jirman <megous@...ous.com>
> ---
> Changes in v2:
> - spaces -> tabs
> 
>  drivers/gpu/drm/sun4i/sun4i_drv.c | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
> index a5757b11b730..c519d7cfcf43 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_drv.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
> @@ -346,6 +346,27 @@ static int sun4i_drv_add_endpoints(struct device *dev,
>  	return count;
>  }
>  
> +#ifdef CONFIG_PM_SLEEP
> +static int sun4i_drv_drm_sys_suspend(struct device *dev)
> +{
> +	struct drm_device *drm = dev_get_drvdata(dev);
> +
> +	return drm_mode_config_helper_suspend(drm);
> +}
> +
> +static int sun4i_drv_drm_sys_resume(struct device *dev)
> +{
> +	struct drm_device *drm = dev_get_drvdata(dev);
> +
> +	return drm_mode_config_helper_resume(drm);
> +}
> +#endif
> +
> +static const struct dev_pm_ops sun4i_drv_drm_pm_ops = {
> +	SET_SYSTEM_SLEEP_PM_OPS(sun4i_drv_drm_sys_suspend,
> +				sun4i_drv_drm_sys_resume)
> +};

I wonder whether we should have these as default helpers somewhere,
there's probably a few drivers that could use them? It's just a handful of
lines we're saving here, but we have enough kms drivers to justify this
kind of stuff nowadays ...
-Daniel

> +
>  static int sun4i_drv_probe(struct platform_device *pdev)
>  {
>  	struct component_match *match = NULL;
> @@ -418,6 +439,7 @@ static struct platform_driver sun4i_drv_platform_driver = {
>  	.driver		= {
>  		.name		= "sun4i-drm",
>  		.of_match_table	= sun4i_drv_of_table,
> +		.pm = &sun4i_drv_drm_pm_ops,
>  	},
>  };
>  module_platform_driver(sun4i_drv_platform_driver);
> -- 
> 2.23.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch