linux-kernel - Re: [PATCH] ACPICA: Enable sleep button on ACPI legacy wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CEC4A132-0FBC-4DC0-8C8F-84608AD8A91A@amazon.com>
Date:   Mon, 4 Nov 2019 17:58:16 +0000
From:   "Agarwal, Anchal" <anchalag@...zon.com>
To:     "Schmauss, Erik" <erik.schmauss@...el.com>
CC:     "Moore, Robert" <robert.moore@...el.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "devel@...ica.org" <devel@...ica.org>
Subject: Re: [PATCH] ACPICA: Enable sleep button on ACPI legacy wake

Apologies for resending it. Looks like it does not show in cc list it went to all mailing list however the thread do appear on lkml. 
Thanks,
Anchal
    
        + Rafael, Bob
        
        Also, is there a reason why this wasn't CC-ed to linux-acpi mailing list? It would be good to get feedback from there too..
    I think I did to all the email id's generated from get_maintainer.pl. Ccing again 
    + linux-acpi
    
        Thanks,
        Erik
        
        > -----Original Message-----
        > From: Anchal Agarwal <anchalag@...zon.com>
        > Sent: Monday, October 29, 2018 10:52 AM
        > Subject: [PATCH] ACPICA: Enable sleep button on ACPI legacy wake
        > 
        > Currently we do not see sleep_enable bit set after guest resumes from
        > hibernation. Hibernation is triggered in guest on receiving a sleep trigger
        > from the hypervisor(S4 state). We see that power button is enabled on wake
        > up from S4 state however sleep button isn't. This causes subsequent
        > invocation of sleep state to fail in the guest. Any environment  going through
        > acpi_hw_legacy_wake() won't have sleep button enabled.
        > 
        > Signed-off-by: Anchal Agarwal <anchalag@...zon.com>
        > Reviewed-by: Balbir Singh <sblbir@...zon.com>
        > Reviewed-by: Frank van der Linden <fllinden@...zon.com>
        > ---
        >  drivers/acpi/acpica/hwsleep.c | 11 +++++++++++
        >  1 file changed, 11 insertions(+)
        > 
        > diff --git a/drivers/acpi/acpica/hwsleep.c b/drivers/acpi/acpica/hwsleep.c
        > index b62db8ec446f..a176c7802760 100644
        > --- a/drivers/acpi/acpica/hwsleep.c
        > +++ b/drivers/acpi/acpica/hwsleep.c
        > @@ -300,6 +300,17 @@ acpi_status acpi_hw_legacy_wake(u8 sleep_state)
        >  				    [ACPI_EVENT_POWER_BUTTON].
        >  				    status_register_id, ACPI_CLEAR_STATUS);
        > 
        > +	/* Enable sleep button */
        > +	(void)
        > +	      acpi_write_bit_register(acpi_gbl_fixed_event_info
        > +				      [ACPI_EVENT_SLEEP_BUTTON].
        > +				      enable_register_id,
        > ACPI_ENABLE_EVENT);
        > +
        > +	(void)
        > +	      acpi_write_bit_register(acpi_gbl_fixed_event_info
        > +				      [ACPI_EVENT_SLEEP_BUTTON].
        > +				      status_register_id, ACPI_CLEAR_STATUS);
        > +
        >  	acpi_hw_execute_sleep_method(METHOD_PATHNAME__SST,
        > ACPI_SST_WORKING);
        >  	return_ACPI_STATUS(status);
        >  }
        > --
        > 2.15.3.AMZN