linux-kernel - Re: [PATCH 1/2] ARM: dts: bcm2711: force CMA into first GB of memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b53f901-09d1-a307-b88e-f1da13eedaaf@gmail.com>
Date:   Mon, 4 Nov 2019 10:48:57 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Stefan Wahren <wahrenst@....net>,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        catalin.marinas@....com, devicetree@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Eric Anholt <eric@...olt.net>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: bcm2711: force CMA into first GB of memory

On 11/4/19 9:51 AM, Florian Fainelli wrote:
> On 11/4/19 9:09 AM, Stefan Wahren wrote:
> 
> [snip]
> 
>>> +	reserved-memory {
>>> +		#address-cells = <2>;
>>> +		#size-cells = <1>;
>>> +		ranges;
>>> +
>>> +		/*
>>> +		 * arm64 reserves the CMA by default somewhere in ZONE_DMA32,
>>> +		 * that's not good enough for the Raspberry Pi 4 as some
>>> +		 * devices can only address the lower 1G of memory (ZONE_DMA).
>>> +		 */
>>> +		linux,cma {
>>> +			compatible = "shared-dma-pool";
>>> +			size = <0x2000000>; /* 32MB */
>>> +			alloc-ranges = <0x0 0x00000000 0x40000000>;
>>> +			reusable;
>>> +			linux,cma-default;
>>> +		};
>>> +	};
>>> +
>>
>> i think this is a SoC-specific issue not a board specifc one. Please
>> move this to bcm2711.dtsi
> 
> This sounds like a possibly fragile solution if someone changes
> CONFIG_CMA_SIZE_MBYTES to a value greater than 32MB no?
> 
> I know we don't want machine descriptors for ARM64 kernels, but since
> there is already a specific 2711 machine compatible string check, maybe
> you could use that as well for determining whether arm64_dma_phys_limit
> or arm64_dma32_phys_limit should be chosen?

This last sentence was referring to an earlier version of another patch
series, this is not being done right now, although ARCH_BCM2835 does
forcibly select ZONE_DMA. Nevermind then, I do not see a cleaner
solution right now either.
-- 
Florian