linux-kernel - [PATCH -next] mm/ptdump: fix a -Wold-style-declaration warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon,  4 Nov 2019 14:23:05 -0500
From:   Qian Cai <cai@....pw>
To:     akpm@...ux-foundation.org
Cc:     steven.price@....com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Qian Cai <cai@....pw>
Subject: [PATCH -next] mm/ptdump: fix a -Wold-style-declaration warning

The -next commit "mm: add generic ptdump" [1] introduced a GCC
compilation warning,

mm/ptdump.c:123:1: warning: 'static' is not at beginning of declaration
[-Wold-style-declaration]
 const static struct mm_walk_ops ptdump_ops = {
 ^~~~~

[1] http://lkml.kernel.org/r/20191028135910.33253-20-steven.price@arm.com

Signed-off-by: Qian Cai <cai@....pw>
---
 mm/ptdump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/ptdump.c b/mm/ptdump.c
index 5d349311e77e..a30ea0cf6c5f 100644
--- a/mm/ptdump.c
+++ b/mm/ptdump.c
@@ -120,7 +120,7 @@ static int ptdump_hole(unsigned long addr, unsigned long next,
 	return 0;
 }
 
-const static struct mm_walk_ops ptdump_ops = {
+static const struct mm_walk_ops ptdump_ops = {
 	.pgd_entry	= ptdump_pgd_entry,
 	.p4d_entry	= ptdump_p4d_entry,
 	.pud_entry	= ptdump_pud_entry,
-- 
1.8.3.1