linux-kernel - Re: [PATCH net-next 1/4] net: ethernet: stmmac: Add support for syscfg clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191104.113344.1336648901043158957.davem@davemloft.net>
Date:   Mon, 04 Nov 2019 11:33:44 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     christophe.roullier@...com
Cc:     robh@...nel.org, joabreu@...opsys.com, mark.rutland@....com,
        mcoquelin.stm32@...il.com, alexandre.torgue@...com,
        peppe.cavallaro@...com, linux-stm32@...md-mailman.stormreply.com,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
        andrew@...n.ch
Subject: Re: [PATCH net-next 1/4] net: ethernet: stmmac: Add support for
 syscfg clock

From: Christophe Roullier <christophe.roullier@...com>
Date: Mon, 4 Nov 2019 14:25:30 +0100

> +				if (dwmac->syscfg_clk)
> +					goto unprepare_syscfg;
>  				return ret;
 ...
> +unprepare_syscfg:
> +	clk_disable_unprepare(dwmac->syscfg_clk);
> +
> +	return ret;

This is so amazingly silly.  You're doing a goto instead of the
clk_disable_unprepare() call itself.

Please don't do this.